Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1536844

Re: [PATCH 5/7] perf tools: Force fixdep compilation at the start of the build

Show all headers | View raw

On Mon, Dec 05, 2016 at 05:02:51PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, Dec 04, 2016 at 09:42:56PM +0100, Jiri Olsa escreveu:
> > The fixdep tool needs to be built before everything else,
> > because it fixes every object dependency file.
> > 
> > We handle this currently by making all objects to depend
> > on fixdep, which is error prone and is easily forgotten
> > when new object is added.
> > 
> > Instead of this, this patch force fixdep tool to be built
> > as the first target in the separate make session. This way
> > we don't need to handle extra fixdep dependencies and we are
> > certain there's no fixdep race with any parallel make job.
> 
> With your updated version I'm getting this:
> 
> $ make -k O=/tmp/build/perf -C tools/perf install-bin
> <BIG SNIP>
>   LINK     /tmp/build/perf/libperf-gtk.so
>   INSTALL  GTK UI
> install: cannot change permissions of ‘/lib64’: Operation not permitted
> install: cannot create regular file '/lib64/libperf-gtk.so': Permission denied
> Makefile.perf:738: recipe for target 'install-gtk' failed
> make[2]: *** [install-gtk] Error 1
> make[2]: *** Waiting for unfinished jobs....
> Makefile.perf:383: recipe for target 'sub-make' failed
> make[1]: *** [sub-make] Error 2
> Makefile:108: recipe for target 'install-bin' failed
> make: *** [install-bin] Error 2
> make: Leaving directory '/home/acme/git/linux/tools/perf'

hum, tests/make does not cover $HOME installation :-\

anyway, I needed to do more changes and I pushed them all
into my perf/fixes again and now I'm running all tests..

it also has the check-headers.sh fix we discussed

I'll post later today if the tests are ok

thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] perf tools: Force fixdep to be built first Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
  [PATCH 3/7] perf tools: Move install-gtk target into rules area Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] perf tools: Move install-gtk target into rules area tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:30 +0100
  [PATCH 6/7] perf tools: Add non config targets Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] perf tools: Add non config targets tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:40 +0100
  [PATCH 1/7] tools build: Make the .cmd file more readable Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] tools build: Make the .cmd file more readable tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:50 +0100
  [PATCH 2/7] tools build: Move tabs to spaces where suitable Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] tools build: Move tabs to spaces where suitable tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:30 +0100
  [PATCH 5/7] perf tools: Force fixdep compilation at the start of the build Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    Re: [PATCH 5/7] perf tools: Force fixdep compilation at the start of  the build Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-05 21:10 +0100
      Re: [PATCH 5/7] perf tools: Force fixdep compilation at the start of  the build Jiri Olsa <jolsa@redhat.com> - 2016-12-06 11:50 +0100
  [PATCH 7/7] perf tools: Cleanup build directory before each test Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] perf tools: Cleanup build directory before each  test tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:30 +0100
  [PATCH 4/7] perf tools: Move python/perf.so target into rules area Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] perf tools: Move python/perf.so target into rules  area tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:30 +0100

csiph-web