Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1536773

[tip:perf/core] tools build: Make the .cmd file more readable

Show all headers | View raw

Commit-ID:  a5ba0a1a5af312c4b4bfe78dc054d832103ec27d
Gitweb:     http://git.kernel.org/tip/a5ba0a1a5af312c4b4bfe78dc054d832103ec27d
Author:     Jiri Olsa <jolsa@kernel.org>
AuthorDate: Sun, 4 Dec 2016 21:42:52 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 5 Dec 2016 16:04:08 -0300

tools build: Make the .cmd file more readable

Putting extra line between dependencies and cmd_* definition
to make it more readable.

Before:

  $ cat .builtin-top.o.cmd
  ...
  /home/jolsa/kernel/linux-perf/tools/include/linux/stringify.h \
  /home/jolsa/kernel/linux-perf/tools/include/linux/time64.h
  cmd_builtin-top.o := gcc -Wp,-MD,./.builtin-top.o.d -Wp,-MT,builtin-...
  ...

After:

  $ cat .builtin-top.o.cmd
  ...
  /home/jolsa/kernel/linux-perf/tools/include/linux/stringify.h \
  /home/jolsa/kernel/linux-perf/tools/include/linux/time64.h

  cmd_builtin-top.o := gcc -Wp,-MD,./.builtin-top.o.d -Wp,-MT,builtin-...
  ...

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1480884178-8072-2-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/build/Build.include | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/build/Build.include b/tools/build/Build.include
index 62dcf0c..475152c 100644
--- a/tools/build/Build.include
+++ b/tools/build/Build.include
@@ -65,7 +65,7 @@ dep-cmd = $(if $(wildcard $(fixdep)),
            printf '\# cannot find fixdep (%s)\n' $(fixdep) > $(dot-target).cmd; \
            printf '\# using basic dep data\n\n' >> $(dot-target).cmd;           \
            cat $(depfile) >> $(dot-target).cmd;                                 \
-           printf '%s\n' 'cmd_$@ := $(make-cmd)' >> $(dot-target).cmd)
+           printf '\n%s\n' 'cmd_$@ := $(make-cmd)' >> $(dot-target).cmd)
 
 ###
 # if_changed_dep  - execute command if any prerequisite is newer than

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] perf tools: Force fixdep to be built first Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
  [PATCH 3/7] perf tools: Move install-gtk target into rules area Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] perf tools: Move install-gtk target into rules area tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:30 +0100
  [PATCH 6/7] perf tools: Add non config targets Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] perf tools: Add non config targets tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:40 +0100
  [PATCH 1/7] tools build: Make the .cmd file more readable Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] tools build: Make the .cmd file more readable tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:50 +0100
  [PATCH 2/7] tools build: Move tabs to spaces where suitable Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] tools build: Move tabs to spaces where suitable tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:30 +0100
  [PATCH 5/7] perf tools: Force fixdep compilation at the start of the build Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    Re: [PATCH 5/7] perf tools: Force fixdep compilation at the start of  the build Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-12-05 21:10 +0100
      Re: [PATCH 5/7] perf tools: Force fixdep compilation at the start of  the build Jiri Olsa <jolsa@redhat.com> - 2016-12-06 11:50 +0100
  [PATCH 7/7] perf tools: Cleanup build directory before each test Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] perf tools: Cleanup build directory before each  test tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:30 +0100
  [PATCH 4/7] perf tools: Move python/perf.so target into rules area Jiri Olsa <jolsa@kernel.org> - 2016-12-04 21:50 +0100
    [tip:perf/core] perf tools: Move python/perf.so target into rules  area tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-12-06 09:30 +0100

csiph-web