Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1538325

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

Show all headers | View raw

On Thu, Dec 08, 2016 at 05:21:47AM +0000, Bart Van Assche wrote:
> On 12/07/16 18:29, Michael S. Tsirkin wrote:
> > By now, linux is mostly endian-clean. Enabling endian-ness
> > checks for everyone produces about 200 new sparse warnings for me -
> > less than 10% over the 2000 sparse warnings already there.
> >
> > Not a big deal, OTOH enabling this helps people notice
> > they are introducing new bugs.
> >
> > So let's just drop __CHECK_ENDIAN__. Follow-up patches
> > can drop distinction between __bitwise and __bitwise__.
> 
> Hello Michael,
> 
> This patch makes a whole bunch of ccflags-y += -D__CHECK_ENDIAN__ 
> statements obsolete. Have you considered to remove these statements?

Absolutely. Just waiting for feedback on the idea.

> Additionally, there are notable exceptions to the rule that most drivers 
> are endian-clean, e.g. drivers/scsi/qla2xxx. I would appreciate it if it 
> would remain possible to check such drivers with sparse without enabling 
> endianness checks. Have you considered to change #ifdef __CHECK_ENDIAN__ 
> into e.g. #ifndef __DONT_CHECK_ENDIAN__?
> 
> Thanks,
> 
> Bart.

The right thing is probably just to fix these, isn't it?
Until then, why not just ignore the warnings?

-- 
MST

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] linux/types.h: enable endian checks for all sparse builds "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-08 03:40 +0100
  Re: [PATCH] linux/types.h: enable endian checks for all sparse builds Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-12-08 06:30 +0100
    Re: [PATCH] linux/types.h: enable endian checks for all sparse builds "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-08 07:00 +0100
      Re: [PATCH] linux/types.h: enable endian checks for all sparse builds Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-12-08 07:40 +0100
        Re: [PATCH] linux/types.h: enable endian checks for all sparse builds Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-08 12:30 +0100
        Re: [PATCH] linux/types.h: enable endian checks for all sparse builds "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-08 17:20 +0100
          Re: [PATCH] linux/types.h: enable endian checks for all sparse builds "Madhani, Himanshu" <Himanshu.Madhani@cavium.com> - 2016-12-09 07:50 +0100
            Re: [PATCH] linux/types.h: enable endian checks for all sparse builds Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-12-09 16:20 +0100
              Re: [PATCH] linux/types.h: enable endian checks for all sparse builds "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-09 21:50 +0100
  Re: [PATCH] linux/types.h: enable endian checks for all sparse  builds Cornelia Huck <cornelia.huck@de.ibm.com> - 2016-12-08 12:30 +0100

csiph-web