Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1537948

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

From Oleg Drokin <oleg.drokin@intel.com>
Newsgroups linux.kernel
Subject Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space
Date 2016-12-07 18:30 +0100
Message-ID <sLOcy-31p-17@gated-at.bofh.it> (permalink)
References <sJZYt-6OX-17@gated-at.bofh.it> <sLaoN-2aw-11@gated-at.bofh.it> <sLorL-2IR-13@gated-at.bofh.it> <sLMkp-1Oz-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Dec 7, 2016, at 10:20 AM, Quentin Lambert wrote:

> Hi all,
> 
> I am looking at the drivers/staging/lustre/lustre/llite/dir.c:
> 
> 1469                 /* Call mdc_iocontrol */
> 1470                 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, sizeof(fid), &fid,
> 1471                                    &index);
> 1472                 if (rc)
> 
> and sparse says:
> 
> drivers/staging/lustre/lustre/llite/dir.c:1471:37: warning: incorrect type in argument 5 (different address spaces)
> 
> I was wondering if there was any value to add a cast to fix the warning?

These's a sister warning to this one, btw, in
drivers/staging/lustre/lustre/lmv/lmv_obd.c:996:19: warning: cast removes address space of expression

It is an ugly kludge and I guess needs to just be reworked somehow instead to avoid
these ugly games.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Quentin Lambert <lambert.quentin@gmail.com> - 2016-12-02 18:40 +0100
  Re: [PATCH] staging: lustre: Fix a spatch warning due to an  assignment from kernel to user space Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-05 22:00 +0100
  Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Oleg Drokin <oleg.drokin@intel.com> - 2016-12-06 00:00 +0100
    Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due  to an assignment from kernel to user space Quentin Lambert <lambert.quentin@gmail.com> - 2016-12-06 15:00 +0100
      Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due  to an assignment from kernel to user space Quentin Lambert <lambert.quentin@gmail.com> - 2016-12-07 16:30 +0100
        Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due  to an assignment from kernel to user space Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-07 16:40 +0100
          Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due  to an assignment from kernel to user space Quentin Lambert <lambert.quentin@gmail.com> - 2016-12-07 16:50 +0100
            Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due  to an assignment from kernel to user space Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-07 20:30 +0100
              Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning  due to an assignment from kernel to user space James Simmons <jsimmons@infradead.org> - 2016-12-07 21:00 +0100
          Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Oleg Drokin <oleg.drokin@intel.com> - 2016-12-07 18:20 +0100
        Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due  to an assignment from kernel to user space Dan Carpenter <dan.carpenter@oracle.com> - 2016-12-07 16:40 +0100
        Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Oleg Drokin <oleg.drokin@intel.com> - 2016-12-07 18:30 +0100

csiph-web