Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1537947

Re: [PATCH 8/9] arm64: dts: rockchip: partially describe PWM regulators for Gru

From Heiko Stuebner <heiko@sntech.de>
Newsgroups linux.kernel
Subject Re: [PATCH 8/9] arm64: dts: rockchip: partially describe PWM regulators for Gru
Date 2016-12-07 18:30 +0100
Message-ID <sLNTb-2UC-29@gated-at.bofh.it> (permalink)
References <sJLVv-5Ru-3@gated-at.bofh.it> <sJLVw-5Ru-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Brian,

Am Donnerstag, 1. Dezember 2016, 18:27:32 CET schrieb Brian Norris:
> We need to add regulators to the CPU nodes, so cpufreq doesn't think it
> can crank up the clock speed without changing the voltage. However, we
> don't yet have the DT bindings to fully describe the Over Voltage
> Protection (OVP) circuits on these boards. Without that description, we
> might end up changing the voltage too much, too fast.
> 
> Add the pwm-regulator descriptions and associate the CPU OPPs, but leave
> them disabled.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

is there a specific reason for keeping this change separate?
While it is nice for documentation reasons, as it stands now the previous 
patch introduces a regression (cpufreq trying to scale without regulators) and 
immediately fixes it here.

So if you're ok with it, I'd like to merge this one back into the previous 
patch when applying.


Heiko

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 8/9] arm64: dts: rockchip: partially describe PWM regulators for Gru Brian Norris <briannorris@chromium.org> - 2016-12-02 03:40 +0100
  Re: [PATCH 8/9] arm64: dts: rockchip: partially describe PWM  regulators for Gru Brian Norris <briannorris@chromium.org> - 2016-12-07 18:10 +0100
  Re: [PATCH 8/9] arm64: dts: rockchip: partially describe PWM regulators for Gru Heiko Stuebner <heiko@sntech.de> - 2016-12-07 18:30 +0100

csiph-web