Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1537576

[PATCH 2/5] hv: allocate synic pages for all present CPUs

Show all headers | View raw

From: Vitaly Kuznetsov <vkuznets@redhat.com>

It may happen that not all CPUs are online when we do hv_synic_alloc() and
in case more CPUs come online later we may try accessing these allocated
structures.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: <stable@vger.kernel.org>
---
 drivers/hv/hv.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 446802a..c326c67 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -411,7 +411,7 @@ int hv_synic_alloc(void)
 		goto err;
 	}
 
-	for_each_online_cpu(cpu) {
+	for_each_present_cpu(cpu) {
 		hv_context.event_dpc[cpu] = kmalloc(size, GFP_ATOMIC);
 		if (hv_context.event_dpc[cpu] == NULL) {
 			pr_err("Unable to allocate event dpc\n");
@@ -482,7 +482,7 @@ void hv_synic_free(void)
 	int cpu;
 
 	kfree(hv_context.hv_numa_map);
-	for_each_online_cpu(cpu)
+	for_each_present_cpu(cpu)
 		hv_synic_free_cpu(cpu);
 }
 
-- 
1.7.4.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] Drivers: hv: vmbus: Some miscellaneous fixes  kys@exchange.microsoft.com - 2016-12-07 08:30 +0100
  [PATCH 4/5] hv: don't reset hv_context.tsc_page on crash kys@exchange.microsoft.com - 2016-12-07 08:40 +0100
  [PATCH 2/5] hv: allocate synic pages for all present CPUs kys@exchange.microsoft.com - 2016-12-07 08:40 +0100
  [PATCH 3/5] hv: init percpu_list in hv_synic_alloc() kys@exchange.microsoft.com - 2016-12-07 08:40 +0100
  [PATCH 5/5] Drivers: hv: vmbus: Prevent sending data on a rescinded channel kys@exchange.microsoft.com - 2016-12-07 08:40 +0100
  [PATCH 1/5] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() kys@exchange.microsoft.com - 2016-12-07 08:40 +0100

csiph-web