Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1537577

[PATCH 3/5] hv: init percpu_list in hv_synic_alloc()

Show all headers | View raw

From: Vitaly Kuznetsov <vkuznets@redhat.com>

Initializing hv_context.percpu_list in hv_synic_alloc() helps to prevent a
crash in percpu_channel_enq() when not all CPUs were online during
initialization and it naturally belongs there.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: <stable@vger.kernel.org>
---
 drivers/hv/hv.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index c326c67..c11393c 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -457,6 +457,8 @@ int hv_synic_alloc(void)
 			pr_err("Unable to allocate post msg page\n");
 			goto err;
 		}
+
+		INIT_LIST_HEAD(&hv_context.percpu_list[cpu]);
 	}
 
 	return 0;
@@ -552,8 +554,6 @@ void hv_synic_init(void *arg)
 	rdmsrl(HV_X64_MSR_VP_INDEX, vp_index);
 	hv_context.vp_index[cpu] = (u32)vp_index;
 
-	INIT_LIST_HEAD(&hv_context.percpu_list[cpu]);
-
 	/*
 	 * Register the per-cpu clockevent source.
 	 */
-- 
1.7.4.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] Drivers: hv: vmbus: Some miscellaneous fixes  kys@exchange.microsoft.com - 2016-12-07 08:30 +0100
  [PATCH 4/5] hv: don't reset hv_context.tsc_page on crash kys@exchange.microsoft.com - 2016-12-07 08:40 +0100
  [PATCH 2/5] hv: allocate synic pages for all present CPUs kys@exchange.microsoft.com - 2016-12-07 08:40 +0100
  [PATCH 3/5] hv: init percpu_list in hv_synic_alloc() kys@exchange.microsoft.com - 2016-12-07 08:40 +0100
  [PATCH 5/5] Drivers: hv: vmbus: Prevent sending data on a rescinded channel kys@exchange.microsoft.com - 2016-12-07 08:40 +0100
  [PATCH 1/5] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() kys@exchange.microsoft.com - 2016-12-07 08:40 +0100

csiph-web