Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	John Stultz <john.stultz@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver
Date	Wed, 07 Dec 2016 05:20:02 +0100
Message-ID	<sLBS2-3o7-17@gated-at.bofh.it> (permalink)
References	<sLiZ3-7V0-3@gated-at.bofh.it> <sLByG-2XJ-9@gated-at.bofh.it> <sLiZ3-7V0-1@gated-at.bofh.it> <sLByG-2XJ-7@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gp8e0BEY0KXKHx+Jdi6b7RvJSLqdcSNcOIapajuSRWM=; b=Bqwq8vaw2yIY0/E4z1Io7ruop+0i+SGkYXgHcumKZ3xPMB9JOjB+6wr5gpAqWds5x5 V46M8M7IuwfdlbqsEEE+m8UGRPIZXKkWwgy4zgcAZtwCMUPKPb9L9mwylPbL8qxXrt8Q FlX9ZVxWk/JIdKvYGhzU1haV6rcw0e3rMEMn0=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gp8e0BEY0KXKHx+Jdi6b7RvJSLqdcSNcOIapajuSRWM=; b=cJ37PBH8pkQvvBxWQlY7K0G3JeLurhcruBN6sEqRhX31CFmywD8xfkLHilapojjZVO kdq7w8h2aWhYblrmr8+F3MwyAOyzqOALKiSZNHj/NTR/SeUMb93MNiYyDgxY4jYj/Ybd 1KqwoeDZHFiEoDGMkTOomkGtdWbSlHVkpCXvN3Xjhy4PDup0JSzbxPIOhi1dl/XP1GFl pJ/e+FYjL/sIgX2fhNXXIA7Hl2vbNd/+RJcY9uVPrFnK9uK98OtSIh8NdN9Lh1kEL205 Shb+px76YiE9TlGUydQx1oEjadhJLjxh7rUHW6ibsYAaUDqBgTtr7gnHq88Sq3ffbKVE agFA==
X-Gm-Message-State	AKaTC025TVPBx5iOutRr/stwQ4bJ+XLcMIDADSuDsTtKAdh6vuMPKesEg0oAUlICKUKMKQIdq04UR7KCvbP9QNIE
X-Received	by 10.202.189.86 with SMTP id n83mr33770677oif.49.1481084035324; Tue, 06 Dec 2016 20:13:55 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	15
Organization	linux.* mail to news gateway
X-Original-Cc	lkml <linux-kernel@vger.kernel.org>, Wei Xu <xuwei5@hisilicon.com>, Guodong Xu <guodong.xu@linaro.org>, Amit Pundir <amit.pundir@linaro.org>, Rob Herring <robh+dt@kernel.org>, John Youn <johnyoun@synopsys.com>, Douglas Anderson <dianders@chromium.org>, Chen Yu <chenyu56@huawei.com>, Kishon Vijay Abraham I <kishon@ti.com>, Felipe Balbi <felipe.balbi@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux USB List <linux-usb@vger.kernel.org>
X-Original-Date	Tue, 6 Dec 2016 20:13:54 -0800
X-Original-Message-ID	<CALAqxLWRpiCw7xoe6-8wbn8hMrXBjhbUCfA3rh8=YhkAugzHYA@mail.gmail.com>
X-Original-References	<1481011582-7162-1-git-send-email-john.stultz@linaro.org> <CGME20161206080833epcas4p1cb6159fa2eb82cddda8266c84b5bb0d5@epcas4p1.samsung.com> <1481011582-7162-2-git-send-email-john.stultz@linaro.org> <584787FF.6030002@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1537478

Show key headers only | View raw

On Tue, Dec 6, 2016 at 7:54 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi John,
>
> I give a some guide for extcon API.
> This patch uses the deprecated extcon API (extcon_get_cable_state_).
> So, I recommend that you better to use following extcon API:
> - extcon_get_cable_state_()  -> extcon_get_state()
> - extcon_register_notifier() -> devm_extcon_register_notifier()

Many thanks for the pointers! I really appreciate it! I'll rework the
driver accordingly (if JohnY doesn't conclude that the extcon support
here is unnecessary).

thanks
-john

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Stultz <john.stultz@linaro.org> - 2016-12-06 09:10 +0100
  Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Youn <John.Youn@synopsys.com> - 2016-12-07 00:20 +0100
    Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Stultz <john.stultz@linaro.org> - 2016-12-07 01:20 +0100
      Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Youn <John.Youn@synopsys.com> - 2016-12-07 01:30 +0100
        Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Stultz <john.stultz@linaro.org> - 2016-12-07 01:40 +0100
          Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Stultz <john.stultz@linaro.org> - 2016-12-07 02:50 +0100
  Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-07 05:00 +0100
    Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Stultz <john.stultz@linaro.org> - 2016-12-07 05:20 +0100

csiph-web