Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

From	John Stultz <john.stultz@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver
Date	2016-12-07 01:40 +0100
Message-ID	<sLyr7-Nn-1@gated-at.bofh.it> (permalink)
References	<sLiZ3-7V0-3@gated-at.bofh.it> <sLiZ3-7V0-1@gated-at.bofh.it> <sLxbI-6w-13@gated-at.bofh.it> <sLy7L-GS-15@gated-at.bofh.it> <sLyhr-Kg-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 6, 2016 at 4:26 PM, John Youn <John.Youn@synopsys.com> wrote:
> On 12/6/2016 4:05 PM, John Stultz wrote:
>> On Tue, Dec 6, 2016 at 3:17 PM, John Youn <John.Youn@synopsys.com> wrote:
>>> Also, do you really need this at all? Wasn't your system previously
>>> able to detect the ID pin change correctly via the connection id
>>> status change interrupt? This would only be needed if that were not
>>> the case.
>>
>> So it can be made work w/o this, but we needed other hacks because the
>> usb-gadget disconnect logic never triggered when the cable was
>> unplugged. The controller would jump over to host mode, then when we
>> re-plugged in the usb-gadget cable, it would fail often as we never
>> got a disconnect signal.  That's why earlier I was using this hack to
>> force gadget disconnect before the reset was called:
>> https://lkml.org/lkml/2016/10/20/26
>
> Other than the triggering WARN_ON() in fifo init, is there any other
> negative effects?

Well, when we see the WARN_ON, it doesn't connect into usb-gadget
mode. I had to unplug and re-plug the cable.
(The hack I linked to above avoids this, but I suspect its not correct).

Also Amit Pundir had mentioned earlier that the UDC sysfs state
doesn't get reported correctly since it doesn't register the
usb-gadget as unplugged until the cable is re-inserted.

> We are revisiting this fifo init code and I think the fifo init is not
> necessary for USB_RESET purposes. This should get rid of a race
> condition where the EP's are not disabled before attempting to
> initialize their FIFO's. Which should get rid of the WARN_ON().
>
> If this is the only issue, then this will probably resolve it.

(Basically that and the two suspend fixes I sent along in this patchset :).

I'd be happy to test anything you're playing with.

thanks
-john

Thread

[RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Stultz <john.stultz@linaro.org> - 2016-12-06 09:10 +0100
  Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Youn <John.Youn@synopsys.com> - 2016-12-07 00:20 +0100
    Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Stultz <john.stultz@linaro.org> - 2016-12-07 01:20 +0100
      Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Youn <John.Youn@synopsys.com> - 2016-12-07 01:30 +0100
        Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Stultz <john.stultz@linaro.org> - 2016-12-07 01:40 +0100
          Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Stultz <john.stultz@linaro.org> - 2016-12-07 02:50 +0100
  Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver Chanwoo Choi <cw00.choi@samsung.com> - 2016-12-07 05:00 +0100
    Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver John Stultz <john.stultz@linaro.org> - 2016-12-07 05:20 +0100

csiph-web