Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1535503

[PATCH V2 04/15] Drivers: hv: vmbus: Enhance the rescind callback functionality

Show all headers | View raw

From: K. Y. Srinivasan <kys@microsoft.com>

Enhance the rescind callback functionality by permitting the passing of an opaque
pointer. This functionality will be used by vmbus device drivers to implement
rescind related cleanup more efficiently.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/channel_mgmt.c |   11 +++++++----
 include/linux/hyperv.h    |    7 ++++---
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index f9c5827..d83c1ac 100644
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -825,8 +825,10 @@ static void vmbus_onoffer_rescind(struct vmbus_channel_message_header *hdr)
 
 	if (channel->device_obj) {
 		if (channel->chn_rescind_callback) {
-			channel->chn_rescind_callback(channel);
-			goto out;
+			channel->chn_rescind_callback(channel,
+						      channel->rescind_arg);
+			if (is_hvsock_channel(channel))
+				goto out;
 		}
 		/*
 		 * We will have to unregister this device from the
@@ -1215,9 +1217,10 @@ bool vmbus_are_subchannels_present(struct vmbus_channel *primary)
 }
 EXPORT_SYMBOL_GPL(vmbus_are_subchannels_present);
 
-void vmbus_set_chn_rescind_callback(struct vmbus_channel *channel,
-		void (*chn_rescind_cb)(struct vmbus_channel *))
+void vmbus_set_chn_rescind_callback(struct vmbus_channel *channel, void *arg,
+		void (*chn_rescind_cb)(struct vmbus_channel *, void *))
 {
 	channel->chn_rescind_callback = chn_rescind_cb;
+	channel->rescind_arg = arg;
 }
 EXPORT_SYMBOL_GPL(vmbus_set_chn_rescind_callback);
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index 35053f9..a9a0ce4 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -800,7 +800,8 @@ struct vmbus_channel {
 	 * Channel rescind callback. Some channels (the hvsock ones), need to
 	 * register a callback which is invoked in vmbus_onoffer_rescind().
 	 */
-	void (*chn_rescind_callback)(struct vmbus_channel *channel);
+	void (*chn_rescind_callback)(struct vmbus_channel *channel, void *arg);
+	void *rescind_arg;
 
 	/*
 	 * The spinlock to protect the structure. It is being used to protect
@@ -957,8 +958,8 @@ static inline void clear_low_latency_mode(struct vmbus_channel *c)
 void vmbus_set_sc_create_callback(struct vmbus_channel *primary_channel,
 			void (*sc_cr_cb)(struct vmbus_channel *new_sc));
 
-void vmbus_set_chn_rescind_callback(struct vmbus_channel *channel,
-		void (*chn_rescind_cb)(struct vmbus_channel *));
+void vmbus_set_chn_rescind_callback(struct vmbus_channel *channel, void *arg,
+		void (*chn_rescind_cb)(struct vmbus_channel *, void *));
 
 /*
  * Retrieve the (sub) channel on which to send an outgoing request.
-- 
1.7.4.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 01/15] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() kys@exchange.microsoft.com - 2016-12-03 19:40 +0100
  [PATCH V2 06/15] hv: allocate synic pages for all present CPUs kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
    Re: [PATCH V2 06/15] hv: allocate synic pages for all present CPUs Greg KH <gregkh@linuxfoundation.org> - 2016-12-06 11:20 +0100
  [PATCH V2 10/15] hv: make CPU offlining prevention fine-grained kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 03/15] Drivers: hv: vmbus: Prevent sending data on a rescinded channel kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 11/15] hv: don't reset hv_context.tsc_page on crash kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 07/15] hv: init percpu_list in hv_synic_alloc() kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
    Re: [PATCH V2 07/15] hv: init percpu_list in hv_synic_alloc() Greg KH <gregkh@linuxfoundation.org> - 2016-12-06 11:20 +0100
  [PATCH V2 15/15] hyperv: Add a function to detect if the device is a vmbus dev kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
    Re: [PATCH V2 15/15] hyperv: Add a function to detect if the device  is a vmbus dev Greg KH <gregkh@linuxfoundation.org> - 2016-12-06 12:00 +0100
      RE: [PATCH V2 15/15] hyperv: Add a function to detect if the device  is a vmbus dev KY Srinivasan <kys@microsoft.com> - 2016-12-06 16:20 +0100
  [PATCH V2 08/15] hv: change clockevents unbind tactics kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 05/15] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels() kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 09/15] hv: switch to cpuhp state machine for synic init/cleanup kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 14/15] Tools: hv: kvp: configurable external scripts path kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 12/15] vmbus: add support for dynamic device id's kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 13/15] uio-hv-generic: new userspace i/o driver for VMBus kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 04/15] Drivers: hv: vmbus: Enhance the rescind callback functionality kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
    Re: [PATCH V2 04/15] Drivers: hv: vmbus: Enhance the rescind  callback functionality Greg KH <gregkh@linuxfoundation.org> - 2016-12-06 11:10 +0100
  Re: [PATCH V2 01/15] Drivers: hv: vmbus: Raise retry/wait limits in  vmbus_post_msg() Greg KH <gregkh@linuxfoundation.org> - 2016-12-06 11:10 +0100

csiph-web