Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1535487

[PATCH V2 06/15] hv: allocate synic pages for all present CPUs

Show all headers | View raw

From: Vitaly Kuznetsov <vkuznets@redhat.com>

It may happen that not all CPUs are online when we do hv_synic_alloc() and
in case more CPUs come online later we may try accessing these allocated
structures.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/hv.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 60dbd6c..e4bb498 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -411,7 +411,7 @@ int hv_synic_alloc(void)
 		goto err;
 	}
 
-	for_each_online_cpu(cpu) {
+	for_each_present_cpu(cpu) {
 		hv_context.event_dpc[cpu] = kmalloc(size, GFP_ATOMIC);
 		if (hv_context.event_dpc[cpu] == NULL) {
 			pr_err("Unable to allocate event dpc\n");
@@ -482,7 +482,7 @@ void hv_synic_free(void)
 	int cpu;
 
 	kfree(hv_context.hv_numa_map);
-	for_each_online_cpu(cpu)
+	for_each_present_cpu(cpu)
 		hv_synic_free_cpu(cpu);
 }
 
-- 
1.7.4.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 01/15] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() kys@exchange.microsoft.com - 2016-12-03 19:40 +0100
  [PATCH V2 06/15] hv: allocate synic pages for all present CPUs kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
    Re: [PATCH V2 06/15] hv: allocate synic pages for all present CPUs Greg KH <gregkh@linuxfoundation.org> - 2016-12-06 11:20 +0100
  [PATCH V2 10/15] hv: make CPU offlining prevention fine-grained kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 03/15] Drivers: hv: vmbus: Prevent sending data on a rescinded channel kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 11/15] hv: don't reset hv_context.tsc_page on crash kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 07/15] hv: init percpu_list in hv_synic_alloc() kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
    Re: [PATCH V2 07/15] hv: init percpu_list in hv_synic_alloc() Greg KH <gregkh@linuxfoundation.org> - 2016-12-06 11:20 +0100
  [PATCH V2 15/15] hyperv: Add a function to detect if the device is a vmbus dev kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
    Re: [PATCH V2 15/15] hyperv: Add a function to detect if the device  is a vmbus dev Greg KH <gregkh@linuxfoundation.org> - 2016-12-06 12:00 +0100
      RE: [PATCH V2 15/15] hyperv: Add a function to detect if the device  is a vmbus dev KY Srinivasan <kys@microsoft.com> - 2016-12-06 16:20 +0100
  [PATCH V2 08/15] hv: change clockevents unbind tactics kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 05/15] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels() kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 09/15] hv: switch to cpuhp state machine for synic init/cleanup kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 14/15] Tools: hv: kvp: configurable external scripts path kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 12/15] vmbus: add support for dynamic device id's kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 13/15] uio-hv-generic: new userspace i/o driver for VMBus kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
  [PATCH V2 04/15] Drivers: hv: vmbus: Enhance the rescind callback functionality kys@exchange.microsoft.com - 2016-12-03 19:50 +0100
    Re: [PATCH V2 04/15] Drivers: hv: vmbus: Enhance the rescind  callback functionality Greg KH <gregkh@linuxfoundation.org> - 2016-12-06 11:10 +0100
  Re: [PATCH V2 01/15] Drivers: hv: vmbus: Raise retry/wait limits in  vmbus_post_msg() Greg KH <gregkh@linuxfoundation.org> - 2016-12-06 11:10 +0100

csiph-web