Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1533975

Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf

From Nicolas Ferre <nicolas.ferre@atmel.com>
Newsgroups linux.kernel
Subject Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf
Date 2016-12-01 12:30 +0100
Message-ID <sJxIR-3bK-5@gated-at.bofh.it> (permalink)
References <sJwMN-2D6-7@gated-at.bofh.it>
Organization atmel

Show all headers | View raw


Le 01/12/2016 à 11:26, Alexandre Belloni a écrit :
> Use devm_kasprintf instead of simple kasprintf to free the allocated memory
> when needed.
> 
> Suggested-by: Peter Rosin <peda@axentia.se>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
>  drivers/usb/gadget/udc/atmel_usba_udc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 45bc997d0711..aec72fe8273c 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -1978,7 +1978,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
>  			dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
>  			goto err;
>  		}
> -		ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", ep->index);
> +		ep->ep.name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "ep%d",
> +					     ep->index);
>  
>  		ep->ep_regs = udc->regs + USBA_EPT_BASE(i);
>  		ep->dma_regs = udc->regs + USBA_DMA_BASE(i);
> 


-- 
Nicolas Ferre

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] usb: gadget: udc: atmel: used managed kasprintf Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-12-01 11:30 +0100
  Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-12-01 12:30 +0100
  RE: [PATCH] usb: gadget: udc: atmel: used managed kasprintf David Laight <David.Laight@ACULAB.COM> - 2016-12-02 17:10 +0100
    Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-12-02 17:30 +0100
      RE: [PATCH] usb: gadget: udc: atmel: used managed kasprintf David Laight <David.Laight@ACULAB.COM> - 2016-12-05 18:20 +0100

csiph-web