Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1535043
| From | David Laight <David.Laight@ACULAB.COM> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH] usb: gadget: udc: atmel: used managed kasprintf |
| Date | 2016-12-02 17:10 +0100 |
| Message-ID | <sJYzn-64D-1@gated-at.bofh.it> (permalink) |
| References | <sJwMN-2D6-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Alexandre Belloni > Sent: 01 December 2016 10:27 > Use devm_kasprintf instead of simple kasprintf to free the allocated memory > when needed. s/when needed/when the device is freed/ > Suggested-by: Peter Rosin <peda@axentia.se> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c > index 45bc997d0711..aec72fe8273c 100644 > --- a/drivers/usb/gadget/udc/atmel_usba_udc.c > +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c > @@ -1978,7 +1978,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, > dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret); > goto err; > } > - ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", ep->index); > + ep->ep.name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "ep%d", > + ep->index); Acually why bother mallocing such a small string at all. The maximum length is 12 bytes even if 'index' are unrestricted. David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] usb: gadget: udc: atmel: used managed kasprintf Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-12-01 11:30 +0100
Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-12-01 12:30 +0100
RE: [PATCH] usb: gadget: udc: atmel: used managed kasprintf David Laight <David.Laight@ACULAB.COM> - 2016-12-02 17:10 +0100
Re: [PATCH] usb: gadget: udc: atmel: used managed kasprintf Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-12-02 17:30 +0100
RE: [PATCH] usb: gadget: udc: atmel: used managed kasprintf David Laight <David.Laight@ACULAB.COM> - 2016-12-05 18:20 +0100
csiph-web