[PATCH] Platform: Exynos-gsc: Clean up file handle in open() error path.

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!newsreader4.netcologne.de!news.netcologne.de!border2.nntp.ams1.giganews.com!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Shailendra Verma <shailendra.v@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH] Platform: Exynos-gsc: Clean up file handle in open() error path.
Date	Thu, 01 Dec 2016 05:50:01 +0100
Message-ID	<sJrtL-7pP-7@gated-at.bofh.it> (permalink)
X-Auditid	cbfee61a-f79916d0000062de-09-583faadfb91d
X-Mailer	git-send-email 1.7.9.5
X-Brightmail-Tracker	H4sIAAAAAAAAA+NgFvrFLMWRmVeSWpSXmKPExsVy+t9jAd37q+wjDD7s5bV483YNk8X246/Y LZY9OM1o0f/4NbPF+fMb2C02Pb7GanF51xw2i54NW1ktZpzfx2SxbNMfJotb82ayWSz69orZ 4u/FS2wOvB47Z91l99i0qpPNY++WLI/NS+o9tvQDRfq2rGL0+LxJLoA9ys0mIzUxJbVIITUv OT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4Ze1bOYSn4 zlpxc8o1xgbGVtYuRk4OCQETiQsX1zNB2GISF+6tZ+ti5OIQEljKKNHc95cVwvnJKPHn3wxm kCo2AUOJ131/mUASIgLPmCWe7u5jB0kwC8hI7JvYBjZKWCBYYvrVg0A2BweLgKrE/C3WIGFe AQ+Jxi1PmEHCEgIKEnMm2Uxg5F7AyLCKUSK1ILmgOCk91zAvtVyvODG3uDQvXS85P3cTIzjc n0ntYDy4y/0QowAHoxIP74I4+wgh1sSy4srcQ4wSHMxKIrznVwKFeFMSK6tSi/Lji0pzUosP MZoCrZ/ILCWanA+MxbySeEMTcxNzYwMLc0tLEyMlcd7G2c/ChQTSE0tSs1NTC1KLYPqYODil GhgnLe5LFTQzstg4++28w3l92s8WKxSGKUwOr8yI8u9ZzaVT/k3O5ZqWiixX7Oq8NXELMq+f Ktqtb2Dy8kvZhytZRfJJC68xnmHhiXQo2Sxz+trCpAtrw6aeniccImrI2T/Z40Xm3iUKR1Oz DNzVJROLOPeU6Wh/D87vct2r/iHz4ZS/KmclTZRYijMSDbWYi4oTAYy4V0SNAgAA
X-Mtr	20000000000000000@CPGS
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	vidushi.koul@samsung.com
X-Original-Date	Thu, 01 Dec 2016 10:12:44 +0530
X-Original-Message-ID	<1480567364-12963-1-git-send-email-shailendra.v@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1533797

Show key headers only | View raw

The File handle is not yet added in the vfd list.So no need to call
v4l2_fh_del(&ctx->fh) if it fails to create control.

Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
---
 drivers/media/platform/exynos-gsc/gsc-m2m.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c
index 9f03b79..5ea97c1 100644
--- a/drivers/media/platform/exynos-gsc/gsc-m2m.c
+++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c
@@ -664,8 +664,8 @@ static int gsc_m2m_open(struct file *file)
 
 error_ctrls:
 	gsc_ctrls_delete(ctx);
-error_fh:
 	v4l2_fh_del(&ctx->fh);
+error_fh:
 	v4l2_fh_exit(&ctx->fh);
 	kfree(ctx);
 unlock:
-- 
1.7.9.5

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] Platform: Exynos-gsc: Clean up file handle in open() error  path. Shailendra Verma <shailendra.v@samsung.com> - 2016-12-01 05:50 +0100

csiph-web