Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1533797 > unrolled thread

[PATCH] Platform: Exynos-gsc: Clean up file handle in open() error path.

Started byShailendra Verma <shailendra.v@samsung.com>
First post2016-12-01 05:50 +0100
Last post2016-12-01 05:50 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH] Platform: Exynos-gsc: Clean up file handle in open() error  path. Shailendra Verma <shailendra.v@samsung.com> - 2016-12-01 05:50 +0100

#1533797 — [PATCH] Platform: Exynos-gsc: Clean up file handle in open() error path.

FromShailendra Verma <shailendra.v@samsung.com>
Date2016-12-01 05:50 +0100
Subject[PATCH] Platform: Exynos-gsc: Clean up file handle in open() error path.
Message-ID<sJrtL-7pP-7@gated-at.bofh.it>
The File handle is not yet added in the vfd list.So no need to call
v4l2_fh_del(&ctx->fh) if it fails to create control.

Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
---
 drivers/media/platform/exynos-gsc/gsc-m2m.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c
index 9f03b79..5ea97c1 100644
--- a/drivers/media/platform/exynos-gsc/gsc-m2m.c
+++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c
@@ -664,8 +664,8 @@ static int gsc_m2m_open(struct file *file)
 
 error_ctrls:
 	gsc_ctrls_delete(ctx);
-error_fh:
 	v4l2_fh_del(&ctx->fh);
+error_fh:
 	v4l2_fh_exit(&ctx->fh);
 	kfree(ctx);
 unlock:
-- 
1.7.9.5

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web