Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1533774
| From | Jason Wang <jasowang@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors |
| Date | 2016-12-01 04:20 +0100 |
| Message-ID | <sJq4F-6F6-11@gated-at.bofh.it> (permalink) |
| References | <sJc1H-61D-15@gated-at.bofh.it> <sJdqO-6Jj-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016年11月30日 21:40, Michael S. Tsirkin wrote:
> On Wed, Nov 30, 2016 at 08:10:57PM +0800, Yunjian Wang wrote:
>> When we meet an error(err=-EBADFD) recvmsg,
> How do you get EBADFD? Won't vhost_net_rx_peek_head_len
> return 0 in this case, breaking the loop?
>
>> the error handling in vhost
>> handle_rx() will continue. This will cause a soft CPU lockup in vhost thread.
>>
>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>> ---
>> drivers/vhost/net.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
>> index 5dc128a..edc470b 100644
>> --- a/drivers/vhost/net.c
>> +++ b/drivers/vhost/net.c
>> @@ -717,6 +717,9 @@ static void handle_rx(struct vhost_net *net)
>> pr_debug("Discarded rx packet: "
>> " len %d, expected %zd\n", err, sock_len);
>> vhost_discard_vq_desc(vq, headcount);
>> + /* Don't continue to do, when meet errors. */
>> + if (err < 0)
>> + goto out;
> You might get e.g. EAGAIN and I think you need to retry
> in this case.
Yes.
>> continue;
>> }
>> /* Supply virtio_net_hdr if VHOST_NET_F_VIRTIO_NET_HDR */
>> --
>> 1.9.5.msysgit.1
>>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH net] vhost_net: don't continue to call the recvmsg when meet errors Yunjian Wang <wangyunjian@huawei.com> - 2016-11-30 13:20 +0100
Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors Jason Wang <jasowang@redhat.com> - 2016-11-30 14:10 +0100
Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors "Michael S. Tsirkin" <mst@redhat.com> - 2016-11-30 14:50 +0100
Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors "Michael S. Tsirkin" <mst@redhat.com> - 2016-11-30 14:50 +0100
RE: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors wangyunjian <wangyunjian@huawei.com> - 2016-12-01 03:50 +0100
Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors Jason Wang <jasowang@redhat.com> - 2016-12-01 04:20 +0100
Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-01 04:30 +0100
Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors Jason Wang <jasowang@redhat.com> - 2016-12-01 04:30 +0100
Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors Jason Wang <jasowang@redhat.com> - 2016-12-01 04:40 +0100
RE: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors wangyunjian <wangyunjian@huawei.com> - 2016-12-01 05:50 +0100
Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-01 06:00 +0100
Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors "Michael S. Tsirkin" <mst@redhat.com> - 2016-12-01 04:40 +0100
Re: [PATCH net] vhost_net: don't continue to call the recvmsg when meet errors Jason Wang <jasowang@redhat.com> - 2016-12-01 04:20 +0100
csiph-web