Re: [PATCH v10 13/13] drm/mediatek: add support for Mediatek SoC MT2701

From	Matthias Brugger <matthias.bgg@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 13/13] drm/mediatek: add support for Mediatek SoC MT2701
Date	2016-11-30 15:10 +0100
Message-ID	<sJdK9-76e-9@gated-at.bofh.it> (permalink)
References	<sHm5c-7PH-9@gated-at.bofh.it> <sHmeS-7T7-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 25/11/16 11:34, YT Shen wrote:

>  static const struct of_device_id mtk_disp_rdma_driver_dt_match[] = {
> +	{ .compatible = "mediatek,mt2701-disp-rdma",
> +	  .data = &mt2701_rdma_driver_data},
>  	{ .compatible = "mediatek,mt8173-disp-rdma",
>  	  .data = &mt8173_rdma_driver_data},
>  	{},

[...]

>  static const struct of_device_id ddp_driver_dt_match[] = {
> +	{ .compatible = "mediatek,mt2701-disp-mutex", .data = mt2701_mutex_mod},
>  	{ .compatible = "mediatek,mt8173-disp-mutex", .data = mt8173_mutex_mod},
>  	{},
>  };

[...]

>
>  static const struct of_device_id mtk_disp_color_driver_dt_match[] = {
> +	{ .compatible = "mediatek,mt2701-disp-color",
> +	  .data = &mt2701_color_driver_data},
>  	{ .compatible = "mediatek,mt8173-disp-color",
>  	  .data = &mt8173_color_driver_data},
>  	{},

[...]

>  static const struct of_device_id mtk_drm_of_ids[] = {
> +	{ .compatible = "mediatek,mt2701-mmsys",
> +	  .data = &mt2701_mmsys_driver_data},
>  	{ .compatible = "mediatek,mt8173-mmsys",
>  	  .data = &mt8173_mmsys_driver_data},
>  	{ }
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 0569f2e..f63cc91 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1203,6 +1203,7 @@ static int mtk_dsi_remove(struct platform_device *pdev)
>  }
>
>  static const struct of_device_id mtk_dsi_of_match[] = {
> +	{ .compatible = "mediatek,mt2701-dsi" },
>  	{ .compatible = "mediatek,mt8173-dsi" },
>  	{ },
>  };

[...]

>
>  static const struct of_device_id mtk_mipi_tx_match[] = {
> +	{ .compatible = "mediatek,mt2701-mipi-tx",
> +	  .data = &mt2701_mipitx_data },
>  	{ .compatible = "mediatek,mt8173-mipi-tx",
>  	  .data = &mt8173_mipitx_data },
>  	{},

I'm not sure if I missed some, but you should update the binding 
description for newly added bindings.

Thanks a lot,
Matthias

Thread

[PATCH v10 00/13] MT2701 DRM support YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:40 +0100
  [PATCH v10 11/13] drm/mediatek: add dsi rxtx control YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
    Re: [PATCH v10 11/13] drm/mediatek: add dsi rxtx control CK Hu <ck.hu@mediatek.com> - 2016-11-30 11:50 +0100
  [PATCH v10 10/13] drm/mediatek: add dsi ulp mode control YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
    Re: [PATCH v10 10/13] drm/mediatek: add dsi ulp mode control CK Hu <ck.hu@mediatek.com> - 2016-12-01 02:20 +0100
  [PATCH v10 09/13] drm/mediatek: add mipi_tx data rate check YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
    Re: [PATCH v10 09/13] drm/mediatek: add mipi_tx data rate check CK Hu <ck.hu@mediatek.com> - 2016-11-30 12:10 +0100
  [PATCH v10 13/13] drm/mediatek: add support for Mediatek SoC MT2701 YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
    Re: [PATCH v10 13/13] drm/mediatek: add support for Mediatek SoC  MT2701 Matthias Brugger <matthias.bgg@gmail.com> - 2016-11-30 15:10 +0100
      Re: [PATCH v10 13/13] drm/mediatek: add support for Mediatek SoC  MT2701 YT Shen <yt.shen@mediatek.com> - 2016-12-05 14:10 +0100
  [PATCH v10 12/13] drm/mediatek: update DSI sub driver flow for sending commands to panel YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
    Re: [PATCH v10 12/13] drm/mediatek: update DSI sub driver flow for  sending commands to panel CK Hu <ck.hu@mediatek.com> - 2016-11-30 09:00 +0100
      Re: [PATCH v10 12/13] drm/mediatek: update DSI sub driver flow for  sending commands to panel YT Shen <yt.shen@mediatek.com> - 2016-12-05 13:50 +0100
  [PATCH v10 06/13] drm/mediatek: cleaning up and refine YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
  [PATCH v10 07/13] drm/mediatek: add dsi interrupt control YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
  [PATCH v10 08/13] drm/mediatek: add dsi transfer function YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
  [PATCH v10 05/13] drm/mediatek: update display module connections YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
  Re: [PATCH v10 00/13] MT2701 DRM support CK Hu <ck.hu@mediatek.com> - 2016-11-30 10:10 +0100

csiph-web