Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1533208

Re: [PATCH v10 11/13] drm/mediatek: add dsi rxtx control

Show all headers | View raw

Hi, YT:

On Fri, 2016-11-25 at 18:34 +0800, YT Shen wrote:
> add non-continuous clock mode and EOT packet control for dsi
> 

I think commit title should be 'drm/mediatek: add non-continuous clock
mode and EOT packet control for dsi', and commit message should describe
more information about this modification. For example, what is the
difference between with and without this patch. Does it fix any problem?

Regards,
CK

> Signed-off-by: shaoming chen <shaoming.chen@mediatek.com>
> Signed-off-by: YT Shen <yt.shen@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 01df829..ded4202 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -399,6 +399,9 @@ static void mtk_dsi_rxtx_control(struct mtk_dsi *dsi)
>  		break;
>  	}
>  
> +	tmp_reg |= (dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) << 6;
> +	tmp_reg |= (dsi->mode_flags & MIPI_DSI_MODE_EOT_PACKET) >> 3;
> +
>  	writel(tmp_reg, dsi->regs + DSI_TXRX_CTRL);
>  }
>  

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v10 00/13] MT2701 DRM support YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:40 +0100
  [PATCH v10 11/13] drm/mediatek: add dsi rxtx control YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
    Re: [PATCH v10 11/13] drm/mediatek: add dsi rxtx control CK Hu <ck.hu@mediatek.com> - 2016-11-30 11:50 +0100
  [PATCH v10 10/13] drm/mediatek: add dsi ulp mode control YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
    Re: [PATCH v10 10/13] drm/mediatek: add dsi ulp mode control CK Hu <ck.hu@mediatek.com> - 2016-12-01 02:20 +0100
  [PATCH v10 09/13] drm/mediatek: add mipi_tx data rate check YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
    Re: [PATCH v10 09/13] drm/mediatek: add mipi_tx data rate check CK Hu <ck.hu@mediatek.com> - 2016-11-30 12:10 +0100
  [PATCH v10 13/13] drm/mediatek: add support for Mediatek SoC MT2701 YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
    Re: [PATCH v10 13/13] drm/mediatek: add support for Mediatek SoC  MT2701 Matthias Brugger <matthias.bgg@gmail.com> - 2016-11-30 15:10 +0100
      Re: [PATCH v10 13/13] drm/mediatek: add support for Mediatek SoC  MT2701 YT Shen <yt.shen@mediatek.com> - 2016-12-05 14:10 +0100
  [PATCH v10 12/13] drm/mediatek: update DSI sub driver flow for sending commands to panel YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
    Re: [PATCH v10 12/13] drm/mediatek: update DSI sub driver flow for  sending commands to panel CK Hu <ck.hu@mediatek.com> - 2016-11-30 09:00 +0100
      Re: [PATCH v10 12/13] drm/mediatek: update DSI sub driver flow for  sending commands to panel YT Shen <yt.shen@mediatek.com> - 2016-12-05 13:50 +0100
  [PATCH v10 06/13] drm/mediatek: cleaning up and refine YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
  [PATCH v10 07/13] drm/mediatek: add dsi interrupt control YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
  [PATCH v10 08/13] drm/mediatek: add dsi transfer function YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
  [PATCH v10 05/13] drm/mediatek: update display module connections YT Shen <yt.shen@mediatek.com> - 2016-11-25 11:50 +0100
  Re: [PATCH v10 00/13] MT2701 DRM support CK Hu <ck.hu@mediatek.com> - 2016-11-30 10:10 +0100

csiph-web