Re: [PATCH v3 11/14] ACPI: irq: introduce interrupt producer

From	Hanjun Guo <hanjun.guo@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 11/14] ACPI: irq: introduce interrupt producer
Date	2016-12-02 11:10 +0100
Message-ID	<sJSWZ-2sV-7@gated-at.bofh.it> (permalink)
References	<swbGa-7lz-3@gated-at.bofh.it> <swbGa-7lz-19@gated-at.bofh.it> <sJxzc-38x-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Aleksey,

On 2016/12/1 19:12, Aleksey Makarov wrote:
>
> Hi Hanjun,
>
> On 10/25/2016 09:09 PM, Hanjun Guo wrote:
>> From: Hanjun Guo <hanjun.guo@linaro.org>
>>
>> In ACPI 6.1 spec, section 19.6.62, Interrupt Resource Descriptor Macro,
>
> [ ... ]
>
>> ---
>>  drivers/acpi/gsi.c      | 10 ++++--
>>  drivers/acpi/resource.c | 85
>> ++++++++++++++++++++++++++++++++++---------------
>>  include/acpi/acpi_bus.h |  1 +
>>  3 files changed, 68 insertions(+), 28 deletions(-)
>>
>> diff --git a/drivers/acpi/gsi.c b/drivers/acpi/gsi.c
>> index ee9e0f2..29ee547 100644
>> --- a/drivers/acpi/gsi.c
>> +++ b/drivers/acpi/gsi.c
>> @@ -55,13 +55,19 @@ int acpi_register_gsi(struct device *dev, u32 gsi,
>> int trigger,
>>                int polarity)
>>  {
>>      struct irq_fwspec fwspec;
>> +    struct acpi_device *adev = dev ? to_acpi_device(dev) : NULL;
>
> Why are you sure dev is always an acpi device?
> Look for example at drivers/acpi/pci_irq.c:377 where this function
> is called for a PCI device

Good catch, but I will drop this patch and use Agustin's one [1].

[1]: https://mail-archive.com/linux-kernel@vger.kernel.org/msg1283116.html

Thanks
Hanjun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 11/14] ACPI: irq: introduce interrupt producer Aleksey Makarov <amakarov.linux@gmail.com> - 2016-12-01 12:20 +0100
  Re: [PATCH v3 11/14] ACPI: irq: introduce interrupt producer Hanjun Guo <hanjun.guo@linaro.org> - 2016-12-02 11:10 +0100

csiph-web