Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1534418

Re: Odd build breakage in 4.9-rc7

From Paul Bolle <pebolle@tiscali.nl>
Newsgroups linux.kernel
Subject Re: Odd build breakage in 4.9-rc7
Date 2016-12-01 21:20 +0100
Message-ID <sJFZM-1tH-13@gated-at.bofh.it> (permalink)
References (5 earlier) <sJl4Z-351-7@gated-at.bofh.it> <sJmNr-4n7-27@gated-at.bofh.it> <sJvxo-1QI-37@gated-at.bofh.it> <sJzUl-4u2-1@gated-at.bofh.it> <sJDEB-7vD-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 2016-12-01 at 12:42 -0500, Nicolas Pitre wrote:
> OK I understand what the problem is.  However most of those hunks below 
> are definitely wrong. ;-)

Probably. By now I've narrowed it down to just these two hunks:

diff --git a/scripts/Makefile b/scripts/Makefile
index 1d80897a9644..f23e5c4f2496 100644
--- a/scripts/Makefile
+++ b/scripts/Makefile
@@ -40,7 +40,9 @@ build_docproc: $(obj)/docproc
 build_check-lc_ctype: $(obj)/check-lc_ctype
 	@:
 
-subdir-$(CONFIG_MODVERSIONS) += genksyms
+ifeq ($(or $(CONFIG_MODVERSIONS),$(CONFIG_TRIM_UNUSED_KSYMS)),y)
+subdir-y                     += genksyms
+endif
 subdir-y                     += mod
 subdir-$(CONFIG_SECURITY_SELINUX) += selinux
 subdir-$(CONFIG_DTC)         += dtc
diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh
index 8dc1918b6783..7525da1cc2f7 100755
--- a/scripts/adjust_autoksyms.sh
+++ b/scripts/adjust_autoksyms.sh
@@ -68,7 +68,7 @@ while read sym; do
 done >> "$new_ksyms_file"
 
 # Special case for modversions (see modpost.c)
-if [ -n "$CONFIG_MODVERSIONS" ]; then
+if [ -n "$CONFIG_MODVERSIONS" -o -n "$CONFIG_TRIM_UNUSED_KSYMS" ]; then
 	echo "#define __KSYM_module_layout 1" >> "$new_ksyms_file"
 fi
 

> I'm trying to determine the best way to fix it. Stay tuned.

Will do. I'm curious to see what a proper fix might look like.

Thanks,


Paul Bolle

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Odd build breakage in 4.9-rc7 Jarod Wilson <jarod@redhat.com> - 2016-11-30 18:30 +0100
  Re: Odd build breakage in 4.9-rc7 Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-30 19:20 +0100
    Re: Odd build breakage in 4.9-rc7 Prarit Bhargava <prarit@redhat.com> - 2016-11-30 19:30 +0100
      Re: Odd build breakage in 4.9-rc7 Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-30 19:40 +0100
        Re: Odd build breakage in 4.9-rc7 Prarit Bhargava <prarit@redhat.com> - 2016-11-30 20:00 +0100
          Re: Odd build breakage in 4.9-rc7 Jarod Wilson <jarod@redhat.com> - 2016-11-30 20:10 +0100
          Re: Odd build breakage in 4.9-rc7 Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-30 20:40 +0100
            Re: Odd build breakage in 4.9-rc7 Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-11-30 23:50 +0100
              Re: Odd build breakage in 4.9-rc7 Prarit Bhargava <prarit@redhat.com> - 2016-12-01 13:50 +0100
              Re: Odd build breakage in 4.9-rc7 Prarit Bhargava <prarit@redhat.com> - 2016-12-01 15:20 +0100
                Re: Odd build breakage in 4.9-rc7 Jarod Wilson <jarod@redhat.com> - 2016-12-01 16:30 +0100
          Re: Odd build breakage in 4.9-rc7 Nicolas Pitre <nico@fluxnic.net> - 2016-12-01 00:20 +0100
  Re: Odd build breakage in 4.9-rc7 Paul Bolle <pebolle@tiscali.nl> - 2016-11-30 22:00 +0100
    Re: Odd build breakage in 4.9-rc7 Jarod Wilson <jarod@redhat.com> - 2016-11-30 22:10 +0100
      Re: Odd build breakage in 4.9-rc7 Jarod Wilson <jarod@redhat.com> - 2016-11-30 22:40 +0100
        Re: Odd build breakage in 4.9-rc7 Paul Bolle <pebolle@tiscali.nl> - 2016-11-30 22:50 +0100
          Re: Odd build breakage in 4.9-rc7 Paul Bolle <pebolle@tiscali.nl> - 2016-11-30 23:00 +0100
            Re: Odd build breakage in 4.9-rc7 Jarod Wilson <jarod@redhat.com> - 2016-12-01 00:50 +0100
              Re: Odd build breakage in 4.9-rc7 Paul Bolle <pebolle@tiscali.nl> - 2016-12-01 10:10 +0100
                Re: Odd build breakage in 4.9-rc7 Paul Bolle <pebolle@tiscali.nl> - 2016-12-01 14:50 +0100
                Re: Odd build breakage in 4.9-rc7 Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-12-01 18:50 +0100
                Re: Odd build breakage in 4.9-rc7 Paul Bolle <pebolle@tiscali.nl> - 2016-12-01 21:20 +0100
                Re: Odd build breakage in 4.9-rc7 Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-12-02 21:20 +0100
                Re: Odd build breakage in 4.9-rc7 Jarod Wilson <jarod@redhat.com> - 2016-12-02 23:50 +0100

csiph-web