Re: [PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC_FIXUP capability for DT platform

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC_FIXUP capability for DT platform
Date	2016-11-30 07:20 +0100
Message-ID	<sJ6pj-2st-15@gated-at.bofh.it> (permalink)
References	<sHPAd-1yq-5@gated-at.bofh.it> <sHPJU-1GL-19@gated-at.bofh.it> <sIalk-6B5-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Boris,

2016-11-28 1:14 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
> On Sun, 27 Nov 2016 03:06:06 +0900
> Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
>> The denali_dt.c was split out by Altera for the SOCFPGA port.  The
>> Denali IP on SOCFPGA incorporates the hardware ECC fixup feature.
>> Newer versions are very likely to support it.  So, it should be OK
>> to set DENALI_CAPS_HW_ECC_FIXUP for all DT platforms.
>
> Seems like a bad idea. What's the problem with setting this flag in the
> data->caps definition of each revision?

No problem.

I will follow your suggestion in v2.


-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC_FIXUP capability for DT platform Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-26 19:20 +0100
  Re: [PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC_FIXUP  capability for DT platform Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-11-27 17:20 +0100
    Re: [PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC_FIXUP  capability for DT platform Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-30 07:20 +0100

csiph-web