Re: [PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC_FIXUP capability for DT platform

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC_FIXUP capability for DT platform
Date	2016-11-27 17:20 +0100
Message-ID	<sIalk-6B5-9@gated-at.bofh.it> (permalink)
References	<sHPAd-1yq-5@gated-at.bofh.it> <sHPJU-1GL-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 27 Nov 2016 03:06:06 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> The denali_dt.c was split out by Altera for the SOCFPGA port.  The
> Denali IP on SOCFPGA incorporates the hardware ECC fixup feature.
> Newer versions are very likely to support it.  So, it should be OK
> to set DENALI_CAPS_HW_ECC_FIXUP for all DT platforms.

Seems like a bad idea. What's the problem with setting this flag in the
data->caps definition of each revision?

> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/mtd/nand/denali_dt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index 293ddb8..9dcd203 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -59,6 +59,8 @@ static int denali_dt_probe(struct platform_device *ofdev)
>  	if (data)
>  		denali->caps = data->caps;
>  
> +	denali->caps |= DENALI_CAPS_HW_ECC_FIXUP;
> +
>  	denali->platform = DT;
>  	denali->dev = &ofdev->dev;
>  	denali->irq = platform_get_irq(ofdev, 0);

Thread

[PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC_FIXUP capability for DT platform Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-26 19:20 +0100
  Re: [PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC_FIXUP  capability for DT platform Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-11-27 17:20 +0100
    Re: [PATCH 20/39] mtd: nand: denali_dt: enable HW_ECC_FIXUP  capability for DT platform Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-30 07:20 +0100

csiph-web