Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1530982
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: fec: turn on device when extracting statistics |
| Date | 2016-11-28 02:40 +0100 |
| Message-ID | <sIj5f-3LB-1@gated-at.bofh.it> (permalink) |
| References | <sHlCa-7En-35@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Date: Fri, 25 Nov 2016 13:02:00 +0300
> + int i, ret;
> +
> + ret = pm_runtime_get_sync(&fep->pdev->dev);
> + if (IS_ERR_VALUE(ret)) {
> + memset(data, 0, sizeof(*data) * ARRAY_SIZE(fec_stats));
> + return;
> + }
This really isn't the way to do this.
When the device is suspended and the clocks are going to be stopped,
you must fetch the statistic values into a software copy and provide
those if the device is suspended when statistics are requested.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: fec: turn on device when extracting statistics Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2016-11-25 11:10 +0100
RE: [PATCH] net: fec: turn on device when extracting statistics Andy Duan <fugang.duan@nxp.com> - 2016-11-27 07:50 +0100
Re: [PATCH] net: fec: turn on device when extracting statistics David Miller <davem@davemloft.net> - 2016-11-28 02:40 +0100
Re: [PATCH] net: fec: turn on device when extracting statistics Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2016-11-28 08:10 +0100
Re: [PATCH] net: fec: turn on device when extracting statistics David Miller <davem@davemloft.net> - 2016-11-28 15:20 +0100
csiph-web