Re: [PATCH 00/29] UBIFS File Encryption v1

From	Eric Biggers <ebiggers@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 00/29] UBIFS File Encryption v1
Date	2016-11-28 02:30 +0100
Message-ID	<sIiVz-3IN-7@gated-at.bofh.it> (permalink)
References	<sDavD-5Ow-3@gated-at.bofh.it> <sDfOI-11Z-91@gated-at.bofh.it> <sHjTH-6yI-11@gated-at.bofh.it> <sIbU5-7vA-11@gated-at.bofh.it> <sIg7o-1WZ-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Nov 27, 2016 at 11:21:56PM +0100, Richard Weinberger wrote:
> Ted,
> 
> On 27.11.2016 18:52, Theodore Ts'o wrote:
> > On Fri, Nov 25, 2016 at 09:18:12AM +0100, Richard Weinberger wrote:
> >>
> >> Do you want us to address Eric's review comments on top of the fscrypt
> >> branch or shall we rebase?
> >> I'd suggest the former.
> > 
> > Yes, let's address them on top of the existing fscrypt branch.  I
> > don't consider any of his comments super-serious --- they were mostly
> > documentation or comments level changes unless I missed something.
> 
> Okay. Then I'll queue UBIFS encryption for the v4.10 merge window.
> Just to be sure, I base my UBIFS next tree on your fscrypt tree such that
> it will build fine and Linus won't see same commits with a different sha1?
> Usually I'm a lucky maintainer and not have to deal with dependencies
> between pull requests. :-)
> 
> Thanks,
> //richard

Shouldn't the branch be rebased to remove the CONFIG_VMAP_STACK fixes which are
already in Linus' tree?

	fscrypto: don't use on-stack buffer for key derivation
	fscrypto: don't use on-stack buffer for filename encryption

Otherwise we'll end up with duplicate commits.

Eric

Thread

Re: [PATCH 00/29] UBIFS File Encryption v1 Theodore Ts'o <tytso@mit.edu> - 2016-11-27 19:00 +0100
  Re: [PATCH 00/29] UBIFS File Encryption v1 Richard Weinberger <richard@nod.at> - 2016-11-27 23:30 +0100
    Re: [PATCH 00/29] UBIFS File Encryption v1 Theodore Ts'o <tytso@mit.edu> - 2016-11-28 01:50 +0100
    Re: [PATCH 00/29] UBIFS File Encryption v1 Eric Biggers <ebiggers@google.com> - 2016-11-28 02:30 +0100
      Re: [PATCH 00/29] UBIFS File Encryption v1 Theodore Ts'o <tytso@mit.edu> - 2016-11-29 03:30 +0100

csiph-web