Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations in blkcg

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations in blkcg
Date	2016-11-29 18:30 +0100
Message-ID	<sIUoa-311-13@gated-at.bofh.it> (permalink)
References	(5 earlier) <sIL1v-5fn-11@gated-at.bofh.it> <sITBL-2rZ-17@gated-at.bofh.it> <sITV8-2B3-11@gated-at.bofh.it> <sIUet-2Xs-7@gated-at.bofh.it> <sIUet-2Xs-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 29-11-16 09:17:37, Linus Torvalds wrote:
> On Tue, Nov 29, 2016 at 9:13 AM, Michal Hocko <mhocko@kernel.org> wrote:
> > How does this look like?
> 
> No.
> 
> I *really* want people to write out that "I am ok with the allocation failing".
> 
> It's not an "inconvenience". It's a sign that you are competent and
> that you know it will fail, and that you can handle it.
> 
> If you don't show that you know that, we warn about it.

How does this warning help those who are watching the logs? What are
they supposed to do about it? Unlike GFP_ATOMIC there is no tuning you
can possibly do.

From my experience people tend to report those and worry about them
(quite often confusing them with the real OOM) and we usually only can
explain that this is nothing to worry about... And so then we sprinkle
GFP_NOWARN all over the place as we hit those. Is this really what we
want?

> And no, "GFP_NOWAIT" does *not* mean "I have a good fallback".

I am confused, how can anybody _rely_ on GFP_NOWAIT to succeed?

-- 
Michal Hocko
SUSE Labs

Thread

Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort  allocations in blkcg Tejun Heo <tj@kernel.org> - 2016-11-28 18:20 +0100
  Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort  allocations in blkcg Michal Hocko <mhocko@kernel.org> - 2016-11-29 08:30 +0100
    Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort  allocations in blkcg Tejun Heo <tj@kernel.org> - 2016-11-29 17:40 +0100
      Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations  in blkcg Vlastimil Babka <vbabka@suse.cz> - 2016-11-29 18:00 +0100
        Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations  in blkcg Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 18:20 +0100
          Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort  allocations in blkcg Michal Hocko <mhocko@kernel.org> - 2016-11-29 18:30 +0100
            Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations  in blkcg Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 18:50 +0100
        Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort  allocations in blkcg Michal Hocko <mhocko@kernel.org> - 2016-11-29 18:20 +0100

csiph-web