Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1532548

Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations in blkcg

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations in blkcg
Date 2016-11-29 18:20 +0100
Message-ID <sIUet-2Xs-5@gated-at.bofh.it> (permalink)
References (6 earlier) <sIxKW-4YT-29@gated-at.bofh.it> <sIL1v-5fn-11@gated-at.bofh.it> <sITBL-2rZ-17@gated-at.bofh.it> <sITV8-2B3-11@gated-at.bofh.it> <sIUet-2Xs-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 29, 2016 at 9:13 AM, Michal Hocko <mhocko@kernel.org> wrote:
> How does this look like?

No.

I *really* want people to write out that "I am ok with the allocation failing".

It's not an "inconvenience". It's a sign that you are competent and
that you know it will fail, and that you can handle it.

If you don't show that you know that, we warn about it.

And no, "GFP_NOWAIT" does *not* mean "I have a good fallback".

             Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort  allocations in blkcg Tejun Heo <tj@kernel.org> - 2016-11-28 18:20 +0100
  Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort  allocations in blkcg Michal Hocko <mhocko@kernel.org> - 2016-11-29 08:30 +0100
    Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort  allocations in blkcg Tejun Heo <tj@kernel.org> - 2016-11-29 17:40 +0100
      Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations  in blkcg Vlastimil Babka <vbabka@suse.cz> - 2016-11-29 18:00 +0100
        Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations  in blkcg Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 18:20 +0100
          Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort  allocations in blkcg Michal Hocko <mhocko@kernel.org> - 2016-11-29 18:30 +0100
            Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort allocations  in blkcg Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 18:50 +0100
        Re: [PATCH] block,blkcg: use __GFP_NOWARN for best-effort  allocations in blkcg Michal Hocko <mhocko@kernel.org> - 2016-11-29 18:20 +0100

csiph-web