Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1530219

[PATCH 2/7] hv: allocate synic pages for all present CPUs

Show all headers | View raw

It may happen that not all CPUs are online when we do hv_synic_alloc() and
in case more CPUs come online later we may try accessing these allocated
structures.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/hv/hv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 60dbd6c..e4bb498 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -411,7 +411,7 @@ int hv_synic_alloc(void)
 		goto err;
 	}
 
-	for_each_online_cpu(cpu) {
+	for_each_present_cpu(cpu) {
 		hv_context.event_dpc[cpu] = kmalloc(size, GFP_ATOMIC);
 		if (hv_context.event_dpc[cpu] == NULL) {
 			pr_err("Unable to allocate event dpc\n");
@@ -482,7 +482,7 @@ void hv_synic_free(void)
 	int cpu;
 
 	kfree(hv_context.hv_numa_map);
-	for_each_online_cpu(cpu)
+	for_each_present_cpu(cpu)
 		hv_synic_free_cpu(cpu);
 }
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:00 +0100
  [PATCH 4/7] hv: change clockevents unbind tactics Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:00 +0100
  [PATCH 6/7] hv: switch to cpuhp state machine for synic init/cleanup Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:00 +0100
  [PATCH 3/7] hv: init percpu_list in hv_synic_alloc() Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:00 +0100
  [PATCH 1/7] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels() Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:10 +0100
    RE: [PATCH 1/7] hv: acquire vmbus_connection.channel_mutex in  vmbus_free_channels() Dexuan Cui <decui@microsoft.com> - 2016-11-28 07:40 +0100
  [PATCH 2/7] hv: allocate synic pages for all present CPUs Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:10 +0100
  Re: [PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Stephen Hemminger <stephen@networkplumber.org> - 2016-11-26 18:10 +0100
    RE: [PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Dexuan Cui <decui@microsoft.com> - 2016-11-28 08:00 +0100
      Re: [PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-28 10:20 +0100

csiph-web