Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1530201

[PATCH 3/7] hv: init percpu_list in hv_synic_alloc()

Show all headers | View raw

Initializing hv_context.percpu_list in hv_synic_alloc() helps to prevent a
crash in percpu_channel_enq() when not all CPUs were online during
initialization and it naturally belongs there.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/hv/hv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index e4bb498..a2567a4 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -457,6 +457,8 @@ int hv_synic_alloc(void)
 			pr_err("Unable to allocate post msg page\n");
 			goto err;
 		}
+
+		INIT_LIST_HEAD(&hv_context.percpu_list[cpu]);
 	}
 
 	return 0;
@@ -552,8 +554,6 @@ void hv_synic_init(void *arg)
 	rdmsrl(HV_X64_MSR_VP_INDEX, vp_index);
 	hv_context.vp_index[cpu] = (u32)vp_index;
 
-	INIT_LIST_HEAD(&hv_context.percpu_list[cpu]);
-
 	/*
 	 * Register the per-cpu clockevent source.
 	 */
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:00 +0100
  [PATCH 4/7] hv: change clockevents unbind tactics Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:00 +0100
  [PATCH 6/7] hv: switch to cpuhp state machine for synic init/cleanup Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:00 +0100
  [PATCH 3/7] hv: init percpu_list in hv_synic_alloc() Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:00 +0100
  [PATCH 1/7] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels() Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:10 +0100
    RE: [PATCH 1/7] hv: acquire vmbus_connection.channel_mutex in  vmbus_free_channels() Dexuan Cui <decui@microsoft.com> - 2016-11-28 07:40 +0100
  [PATCH 2/7] hv: allocate synic pages for all present CPUs Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-25 14:10 +0100
  Re: [PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Stephen Hemminger <stephen@networkplumber.org> - 2016-11-26 18:10 +0100
    RE: [PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Dexuan Cui <decui@microsoft.com> - 2016-11-28 08:00 +0100
      Re: [PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-11-28 10:20 +0100

csiph-web