Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array
Date	2016-11-25 09:10 +0100
Message-ID	<sHjK2-6sh-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <sDmn7-5BA-1@gated-at.bofh.it> <sGhqW-6tz-11@gated-at.bofh.it> <sGmAn-1lo-43@gated-at.bofh.it> <sH2Jc-3tF-27@gated-at.bofh.it> <sH5xo-5lp-11@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Thu, Nov 24, 2016 at 09:53:13AM -0700, Jason Gunthorpe wrote:
> On Thu, Nov 24, 2016 at 03:57:23PM +0200, Jarkko Sakkinen wrote:
> > I manually added the changes to:
> > 
> >   tpm: replace dynamically allocated bios_dir with a static array
> 
> For this patch..
> 
> Could drop 'int rc' from tpm1_chip_register, but it will come back in
> a later patch
> 
> Could dump TPM_NUM_EVENT_LOG_FILES and just use
> ARRAY_SIZE(chip->bios_dir)

Not a bug fix. Happy take a patch after the pull request.

> Now the the stub for tpm_bios_log_setup can properly return -ENODEV
> 
> This is no good at this point in the series - we need the ENODEV
> detection in tpm_chip_register() from the 'Fix handle of missing event
> log' moved into this patch, because it now returns ENODEV due to
> sercurityfs

Sure it would be cleaner but not really necessary. Do you really think
this is mandatory? No matter how I reorder patches this will require
time and effort to fix various merge conflicts because of the replacemnt
of event log. After that I have to test everything.

Not doing this for light reasons...

> The commit 'tpm: vtpm_proxy: Do not access host's event log' still
> needs a proper commit message - it doesn't match what the patch is
> doing at all.

The commit message otherwise great except for the short summary, which
is now fixed.

> If you are going to be editing the patches I'd suggest squashing all
> the bug fix ones with proper credit so it at least makes sense to
> read..
> 
> Jason

I do not have interest to edit patches more than I have to.

/Jarkko

Thread

[PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array Nayna Jain <nayna@linux.vnet.ibm.com> - 2016-11-14 11:10 +0100
  Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with  a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-22 12:30 +0100
    Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with  a static array Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-22 18:00 +0100
      Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with  a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-24 15:00 +0100
        Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with  a static array Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-24 18:00 +0100
          Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with  a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-25 09:10 +0100
            Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with  a static array Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-25 20:40 +0100
              Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with  a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-26 14:00 +0100
    Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a  static array Nayna <nayna@linux.vnet.ibm.com> - 2016-11-22 20:30 +0100
      Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with  a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-24 15:10 +0100

csiph-web