Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with a static array
Date	2016-11-26 14:00 +0100
Message-ID	<sHKKe-6IQ-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <sGmAn-1lo-43@gated-at.bofh.it> <sH2Jc-3tF-27@gated-at.bofh.it> <sH5xo-5lp-11@gated-at.bofh.it> <sHjK2-6sh-7@gated-at.bofh.it> <sHuvM-4HW-17@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Fri, Nov 25, 2016 at 12:38:13PM -0700, Jason Gunthorpe wrote:
> On Fri, Nov 25, 2016 at 10:08:38AM +0200, Jarkko Sakkinen wrote:
> 
> > > This is no good at this point in the series - we need the ENODEV
> > > detection in tpm_chip_register() from the 'Fix handle of missing event
> > > log' moved into this patch, because it now returns ENODEV due to
> > > sercurityfs
> > 
> > Sure it would be cleaner but not really necessary. Do you really think
> > this is mandatory? No matter how I reorder patches this will require
> > time and effort to fix various merge conflicts because of the replacemnt
> > of event log. After that I have to test everything.
> 
> Well, once you started editing patches to fix them you should make
> them fully correct so bisection works.
> 
> If you applied the patch I gave you on top of the tree then I would
> have said to leave it...

I agree with you on this. I adjusted it to be like that now. Is it good
now?

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with  a static array Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-25 20:40 +0100
  Re: [PATCH v6 3/9] tpm: replace dynamically allocated bios_dir with  a static array Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-11-26 14:00 +0100

csiph-web