Re: [PATCH] SMB2: Fix share type handling

From	Aurélien Aptel <aaptel@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] SMB2: Fix share type handling
Date	2016-11-22 13:20 +0100
Message-ID	<sGidj-72S-5@gated-at.bofh.it> (permalink)
References	<sG4N4-6GD-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Christophe JAILLET <christophe.jaillet@wanadoo.fr> writes:
> Knowing that, with the current code, the SMB2_SHARE_TYPE_PRINT case can
> never trigger and printer share would be interpreted as disk share.

I've checked the SMB2 specs ([MS-SMB2] 3.2.5.5), I can confirm these are
the 3 only options. No upper bits are supposed to be set.

> So, test the ShareType value for equality instead.
>
> While at it, add some { } to fix a small style issue.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile-tested only.
>
> The proposed patch changes a bit the semantic as no masking is performed
> anymore. If some upper bits in 'ShareType' are set, it would now be rejected
> instead of silently accepted.

The semantic change is correct. I also think a switch would be more
appropriate. Beside this, Looks Good To Me.

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] SMB2: Fix share type handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-11-21 23:00 +0100
  Re: [PATCH] SMB2: Fix share type handling walter harms <wharms@bfs.de> - 2016-11-22 09:30 +0100
  Re: [PATCH] SMB2: Fix share type handling Aurélien Aptel <aaptel@suse.com> - 2016-11-22 13:20 +0100

csiph-web