Re: [PATCH 1/3] of: base: add support to get machine compatible string

From	Sekhar Nori <nsekhar@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] of: base: add support to get machine compatible string
Date	2016-11-22 13:20 +0100
Message-ID	<sGidj-72S-1@gated-at.bofh.it> (permalink)
References	<sGgOd-61X-1@gated-at.bofh.it> <sGgOe-61X-33@gated-at.bofh.it> <sGgXT-65c-11@gated-at.bofh.it> <sGgXT-65c-17@gated-at.bofh.it> <sGh7z-6nn-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 22 November 2016 04:36 PM, Sudeep Holla wrote:
> 
> 
> On 22/11/16 10:57, Bartosz Golaszewski wrote:
>> 2016-11-22 11:53 GMT+01:00 Sudeep Holla <sudeep.holla@arm.com>:
>>>
>>>
>>> On 22/11/16 10:41, Bartosz Golaszewski wrote:
>>>>
>>>> Add a function allowing to retrieve the compatible string of the root
>>>> node of the device tree.
>>>>
>>>
>>> Rob has queued [1] and it's in -next today. You can reuse that if you
>>> are planning to target this for v4.11 or just use open coding in your
>>> driver for v4.10 and target this move for v4.11 to avoid cross tree
>>> dependencies as I already mentioned in your previous thread.
>>
>> Rob's patch checks the model first - I'm not sure this is the behavior
>> we want here as Sekhar suggested we print the machine compatible.
> 
> IIUC, you are replacing of_flat_dt_get_machine_name and
> of_machine_get_model_name does exactly same. So I don't see any point in
> adding this new function and it's just used for logging purpose.
> Also Sekhar just gave example by using just compatible adding that
> function in the driver itself.
> 
> As Arnd suggested me[1], you should for v4.10 fix it in the driver
> itself to avoid the cross tree dependencies at this point similar to [2]

+1. Bartosz, can you please fix it in the driver for v4.10. If there is
an API available, we can move to it for v4.11

Thanks,
Sekhar

Thread

[PATCH 0/3] ARM: da8xx: fix section mismatch in new drivers Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-22 11:50 +0100
  [PATCH 2/3] bus: da8xx-mstpri: drop the call to of_flat_dt_get_machine_name() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-22 11:50 +0100
  [PATCH 3/3] memory: da8xx-ddrctl: drop the call to of_flat_dt_get_machine_name() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-22 11:50 +0100
  [PATCH 1/3] of: base: add support to get machine compatible string Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-22 11:50 +0100
    Re: [PATCH 1/3] of: base: add support to get machine compatible  string Sudeep Holla <sudeep.holla@arm.com> - 2016-11-22 12:00 +0100
      Re: [PATCH 1/3] of: base: add support to get machine compatible string Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-22 12:00 +0100
        Re: [PATCH 1/3] of: base: add support to get machine compatible string Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-22 12:00 +0100
        Re: [PATCH 1/3] of: base: add support to get machine compatible  string Sudeep Holla <sudeep.holla@arm.com> - 2016-11-22 12:10 +0100
          Re: [PATCH 1/3] of: base: add support to get machine compatible  string Sekhar Nori <nsekhar@ti.com> - 2016-11-22 13:20 +0100
      Re: [PATCH 1/3] of: base: add support to get machine compatible  string Sekhar Nori <nsekhar@ti.com> - 2016-11-22 16:10 +0100
        Re: [PATCH 1/3] of: base: add support to get machine compatible  string Sudeep Holla <sudeep.holla@arm.com> - 2016-11-22 16:50 +0100
          Re: [PATCH 1/3] of: base: add support to get machine compatible  string Sekhar Nori <nsekhar@ti.com> - 2016-11-23 09:00 +0100
            Re: [PATCH 1/3] of: base: add support to get machine compatible  string Sudeep Holla <sudeep.holla@arm.com> - 2016-11-23 11:10 +0100
              Re: [PATCH 1/3] of: base: add support to get machine compatible  string Sekhar Nori <nsekhar@ti.com> - 2016-11-23 12:50 +0100
                Re: [PATCH 1/3] of: base: add support to get machine compatible  string Sekhar Nori <nsekhar@ti.com> - 2016-11-23 13:20 +0100
                Re: [PATCH 1/3] of: base: add support to get machine compatible  string Sudeep Holla <sudeep.holla@arm.com> - 2016-11-23 13:20 +0100
                Re: [PATCH 1/3] of: base: add support to get machine compatible  string Sudeep Holla <sudeep.holla@arm.com> - 2016-11-23 13:20 +0100

csiph-web