Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1527312

Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

Show all headers | View raw

On Tue, Nov 22, 2016 at 08:54:18AM +0100, Martin Kaiser wrote:
> The HM and TM fields in the LCDC DMA Control Register are 7 bits wide.
> Use the correct mask to allow setting all possible bits.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> 
> This bug was discovered on a board that uses DMACR_TM(16). We ended up
> with TM==0 in the register, the upper three bits were filtered out.
> 
> The LCD DMA Control Register is described in section 33.3.16 of the
> IMX25 reference manual.

For the MX1 which is also supported by this driver, the definitions are
right. So this needs a more sophisticated patch. Also I wonder why the
register definition is in include/linux/platform_data and not in the
driver directly.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Martin Kaiser <martin@kaiser.cx> - 2016-11-22 09:00 +0100
  Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-11-22 09:50 +0100
    Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Martin Kaiser <martin@kaiser.cx> - 2016-11-23 10:40 +0100
      Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-11-23 11:00 +0100
        Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Martin Kaiser <martin@kaiser.cx> - 2016-11-25 09:50 +0100

csiph-web