Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1527284

[PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM

Show all headers | View raw

The HM and TM fields in the LCDC DMA Control Register are 7 bits wide.
Use the correct mask to allow setting all possible bits.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---

This bug was discovered on a board that uses DMACR_TM(16). We ended up
with TM==0 in the register, the upper three bits were filtered out.

The LCD DMA Control Register is described in section 33.3.16 of the
IMX25 reference manual.

 include/linux/platform_data/video-imxfb.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/platform_data/video-imxfb.h b/include/linux/platform_data/video-imxfb.h
index 18e9083..858c66d 100644
--- a/include/linux/platform_data/video-imxfb.h
+++ b/include/linux/platform_data/video-imxfb.h
@@ -48,8 +48,8 @@
 #define LSCR1_GRAY1(x)            (((x) & 0xf))
 
 #define DMACR_BURST	(1 << 31)
-#define DMACR_HM(x)	(((x) & 0xf) << 16)
-#define DMACR_TM(x)	((x) & 0xf)
+#define DMACR_HM(x)	(((x) & 0x7f) << 16)
+#define DMACR_TM(x)	((x) & 0x7f)
 
 struct imx_fb_videomode {
 	struct fb_videomode mode;
-- 
1.7.10.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Martin Kaiser <martin@kaiser.cx> - 2016-11-22 09:00 +0100
  Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-11-22 09:50 +0100
    Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Martin Kaiser <martin@kaiser.cx> - 2016-11-23 10:40 +0100
      Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2016-11-23 11:00 +0100
        Re: [PATCH] video: imxfb: correct the bitmask for DMACR_HM/_TM Martin Kaiser <martin@kaiser.cx> - 2016-11-25 09:50 +0100

csiph-web