Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]
Date	2016-11-24 08:40 +0100
Message-ID	<sGWNr-804-9@gated-at.bofh.it> (permalink)
References	<sGRE6-4x0-3@gated-at.bofh.it> <sGu4N-6a5-5@gated-at.bofh.it> <sGu4N-6a5-3@gated-at.bofh.it> <sGRE6-4x0-3@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Andreas Dilger <adilger@dilger.ca> wrote:

> > +		case S_IFCHR:	printf(" character special file\n");	ft = 'c'; break;
> 
> This will overflow 80 columns.  Could use just "character special"?
> 
> > +		case S_IFDIR:	printf(" directory\n");			ft = 'd'; break;
> > +		case S_IFBLK:	printf(" block special file\n");	ft = 'b'; break;
> > +		case S_IFREG:	printf(" regular file\n");		ft = '-'; break;
> > +		case S_IFLNK:	printf(" symbolic link\n");		ft = 'l'; break;
> 
> Having these all as single-word items would make it easier to parse for
> test programs.  Same with "IO Block:" -> "Blocksize:".  Not a huge deal.

Try doing "stat /dev/null".

David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 0/4] Enhanced file stat system call [ver #3] David Howells <dhowells@redhat.com> - 2016-11-23 02:00 +0100
  [PATCH 4/4] statx: AFS: Return enhanced file attributes [ver #3] David Howells <dhowells@redhat.com> - 2016-11-23 02:10 +0100
    Re: [PATCH 4/4] statx: AFS: Return enhanced file attributes [ver #3] Andreas Dilger <adilger@dilger.ca> - 2016-11-24 03:10 +0100
  Re: [PATCH 1/4] statx: Add a system call to make enhanced file info  available [ver #3] "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-11-23 09:40 +0100
    Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3] Andreas Dilger <adilger@dilger.ca> - 2016-11-23 23:50 +0100
    Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3] Andreas Dilger <adilger@dilger.ca> - 2016-11-24 00:00 +0100
      Re: [PATCH 1/4] statx: Add a system call to make enhanced file info  available [ver #3] "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> - 2016-11-24 09:20 +0100
  Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3] David Howells <dhowells@redhat.com> - 2016-11-24 08:40 +0100

csiph-web