[PATCH 3/3] perf sched timehist: Enlarge max stack depth by 2

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 3/3] perf sched timehist: Enlarge max stack depth by 2
Date	2016-11-24 02:20 +0100
Message-ID	<sGQRI-41E-11@gated-at.bofh.it> (permalink)
References	<sGQRH-41E-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

When it records callchains, they will always have 2 scheduler functions
(__schedule + schedule or __schedule + preempt_schedule) and get
ignored.  So it should collect 2 more functions to show the expected
number of callchains to user.

Cc: David Ahern <dsahern@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 06be809a02ab..a49a032f5b15 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1960,7 +1960,7 @@ static bool is_idle_sample(struct perf_sched *sched,
 		return false;
 
 	if (thread__resolve_callchain(thread, cursor, evsel, sample,
-				      NULL, NULL, sched->max_stack) != 0) {
+				      NULL, NULL, sched->max_stack + 2) != 0) {
 		if (verbose)
 			error("Failed to resolve callchain. Skipping\n");
 
-- 
2.10.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 3/3] perf sched timehist: Enlarge max stack depth by 2 Namhyung Kim <namhyung@kernel.org> - 2016-11-24 02:20 +0100

csiph-web