Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1528724

Re: [PATCH] gpio: Add Tegra186 support

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Nov 23, 2016 at 02:30:45PM +0100, Linus Walleij wrote:
> On Tue, Nov 22, 2016 at 6:55 PM, Thierry Reding
> <thierry.reding@gmail.com> wrote:
> 
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Tegra186 has two GPIO controllers that are largely register compatible
> > between one another but are completely different from the controller
> > found on earlier generations.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> 
> I would prefer if you could try to convert this driver to use
> CONFIG_GPIOLIB_IRQCHIP and install a chained interrupt
> handler with gpiochip_irqchio_add() + gpiolib_set_chained_irqchip().
> It would save us so much trouble and so much complicated
> code to maintain for this custom irqdomain.
> 
> I suggest you to look into the mechanisms mentioned in my
> previous mail for how to poke holes in the single linear
> irqdomain used by this mechanism.
> 
> As it seems, you only have one parent interrupt with all
> these IRQs cascading off it as far as I can tell.

Like I said in other email, I don't think this will work because the
GPIOLIB_IRQCHIP support seems to be limited to cases where a single
parent interrupt is used. We could possibly live with a single IRQ
handler and data, but we definitely need to request multiple IRQs if
we want to be able to use all GPIOs as interrupts.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Thierry Reding <thierry.reding@gmail.com> - 2016-11-22 18:40 +0100
  [PATCH] gpio: Add Tegra186 support Thierry Reding <thierry.reding@gmail.com> - 2016-11-22 19:00 +0100
    Re: [PATCH] gpio: Add Tegra186 support Linus Walleij <linus.walleij@linaro.org> - 2016-11-23 14:40 +0100
      Re: [PATCH] gpio: Add Tegra186 support Thierry Reding <thierry.reding@gmail.com> - 2016-11-23 20:50 +0100
        Re: [PATCH] gpio: Add Tegra186 support Linus Walleij <linus.walleij@linaro.org> - 2016-11-24 16:50 +0100
    Re: [PATCH] gpio: Add Tegra186 support Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-24 08:20 +0100
      Re: [PATCH] gpio: Add Tegra186 support Thierry Reding <thierry.reding@gmail.com> - 2016-11-24 15:50 +0100
        Re: [PATCH] gpio: Add Tegra186 support Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-24 16:10 +0100
          Re: [PATCH] gpio: Add Tegra186 support Thierry Reding <thierry.reding@gmail.com> - 2016-11-24 16:10 +0100
  Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-11-23 14:30 +0100
    Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Thierry Reding <thierry.reding@gmail.com> - 2016-11-23 21:00 +0100
      Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-24 08:00 +0100
        Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Thierry Reding <thierry.reding@gmail.com> - 2016-11-24 16:10 +0100
      Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-11-24 16:10 +0100
        Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Thierry Reding <thierry.reding@gmail.com> - 2016-11-24 17:40 +0100
          Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-11-25 00:30 +0100

csiph-web