Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1528401

Re: [PATCH] gpio: Add Tegra186 support

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] gpio: Add Tegra186 support
Date 2016-11-23 14:40 +0100
Message-ID <sGFWi-5vy-3@gated-at.bofh.it> (permalink)
References <sGnd0-1Py-41@gated-at.bofh.it> <sGnwl-1Wv-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 22, 2016 at 6:55 PM, Thierry Reding
<thierry.reding@gmail.com> wrote:

> From: Thierry Reding <treding@nvidia.com>
>
> Tegra186 has two GPIO controllers that are largely register compatible
> between one another but are completely different from the controller
> found on earlier generations.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

I would prefer if you could try to convert this driver to use
CONFIG_GPIOLIB_IRQCHIP and install a chained interrupt
handler with gpiochip_irqchio_add() + gpiolib_set_chained_irqchip().
It would save us so much trouble and so much complicated
code to maintain for this custom irqdomain.

I suggest you to look into the mechanisms mentioned in my
previous mail for how to poke holes in the single linear
irqdomain used by this mechanism.

As it seems, you only have one parent interrupt with all
these IRQs cascading off it as far as I can tell.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Thierry Reding <thierry.reding@gmail.com> - 2016-11-22 18:40 +0100
  [PATCH] gpio: Add Tegra186 support Thierry Reding <thierry.reding@gmail.com> - 2016-11-22 19:00 +0100
    Re: [PATCH] gpio: Add Tegra186 support Linus Walleij <linus.walleij@linaro.org> - 2016-11-23 14:40 +0100
      Re: [PATCH] gpio: Add Tegra186 support Thierry Reding <thierry.reding@gmail.com> - 2016-11-23 20:50 +0100
        Re: [PATCH] gpio: Add Tegra186 support Linus Walleij <linus.walleij@linaro.org> - 2016-11-24 16:50 +0100
    Re: [PATCH] gpio: Add Tegra186 support Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-24 08:20 +0100
      Re: [PATCH] gpio: Add Tegra186 support Thierry Reding <thierry.reding@gmail.com> - 2016-11-24 15:50 +0100
        Re: [PATCH] gpio: Add Tegra186 support Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-24 16:10 +0100
          Re: [PATCH] gpio: Add Tegra186 support Thierry Reding <thierry.reding@gmail.com> - 2016-11-24 16:10 +0100
  Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-11-23 14:30 +0100
    Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Thierry Reding <thierry.reding@gmail.com> - 2016-11-23 21:00 +0100
      Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Laxman Dewangan <ldewangan@nvidia.com> - 2016-11-24 08:00 +0100
        Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Thierry Reding <thierry.reding@gmail.com> - 2016-11-24 16:10 +0100
      Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-11-24 16:10 +0100
        Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Thierry Reding <thierry.reding@gmail.com> - 2016-11-24 17:40 +0100
          Re: [PATCH] gpio: tegra186: Add support for T186 GPIO Linus Walleij <linus.walleij@linaro.org> - 2016-11-25 00:30 +0100

csiph-web