Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1526854

Re: [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy eee-disable-advert option documentation

Show all headers | View raw

On Mon, Nov 21, 2016 at 04:35:23PM +0100, Jerome Brunet wrote:
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  Documentation/devicetree/bindings/net/phy.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt
> index bc1c3c8bf8fa..7f066b7c1e2c 100644
> --- a/Documentation/devicetree/bindings/net/phy.txt
> +++ b/Documentation/devicetree/bindings/net/phy.txt
> @@ -35,6 +35,11 @@ Optional Properties:
>  - broken-turn-around: If set, indicates the PHY device does not correctly
>    release the turn around line low at the end of a MDIO transaction.
>  
> +- eee-advert-disable: Bits to clear in the MDIO_AN_EEE_ADV register to
> +  disable EEE modes. Example
> +    * 0x4: disable EEE for 1000T,
> +    * 0x6: disable EEE for 100TX and 1000T
> +

Hi Jerome

I like the direction this patchset is taking. But hex values are
pretty unfriendly. Please add a set of boolean properties, and do the
mapping to hex in the C code.

That would also make extending this API easier. e.g. say you have a
10Gbps PHY with EEE, and you need to disable it. This hex value
quickly gets ugly, eee-advert-disable-10000 is nice and simple.

	Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH net v2 0/3] Fix OdroidC2 Gigabit Tx link issue Jerome Brunet <jbrunet@baylibre.com> - 2016-11-21 16:40 +0100
  [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy eee-disable-advert option documentation Jerome Brunet <jbrunet@baylibre.com> - 2016-11-21 16:40 +0100
    Re: [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy  eee-disable-advert option documentation Andrew Lunn <andrew@lunn.ch> - 2016-11-21 17:10 +0100
      Re: [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy  eee-disable-advert option documentation Jerome Brunet <jbrunet@baylibre.com> - 2016-11-21 17:20 +0100
        Re: [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy  eee-disable-advert option documentation Andrew Lunn <andrew@lunn.ch> - 2016-11-21 17:50 +0100
          Re: [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy  eee-disable-advert option documentation Florian Fainelli <f.fainelli@gmail.com> - 2016-11-22 06:40 +0100
            Re: [RFC PATCH net v2 2/3] dt: bindings: add ethernet phy  eee-disable-advert option documentation Jerome Brunet <jbrunet@baylibre.com> - 2016-11-22 11:20 +0100
  [RFC PATCH net v2 3/3] ARM64: dts: meson: odroidc2: disable advertisement EEE for GbE. Jerome Brunet <jbrunet@baylibre.com> - 2016-11-21 16:50 +0100
  Re: [RFC PATCH net v2 0/3] Fix OdroidC2 Gigabit Tx link issue Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2016-11-24 15:50 +0100
    Re: [RFC PATCH net v2 0/3] Fix OdroidC2 Gigabit Tx link issue Jerome Brunet <jbrunet@baylibre.com> - 2016-11-24 17:10 +0100
      Re: [RFC PATCH net v2 0/3] Fix OdroidC2 Gigabit Tx link issue Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2016-11-24 18:30 +0100

csiph-web