Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1526302

[PATCH 3/5] usb: dwc2: fix default value for DMA support

Show all headers | View raw

The current defaults for DMA results on a non-DMA platform in a unnecessary
error message:

  Invalid value 0 for param gadget-dma

So fix this by using dma_capable as default value.

Fixes: 9962b62f1be ("usb: dwc2: Deprecate g-use-dma binding")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 drivers/usb/dwc2/params.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 2c7b624..30b954e 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -1088,7 +1088,7 @@ static void dwc2_set_gadget_dma(struct dwc2_hsotg *hsotg)
 	/* Buffer DMA */
 	dwc2_set_param_bool(hsotg, &p->g_dma,
 			    false, "gadget-dma",
-			    true, false,
+			    dma_capable, false,
 			    dma_capable);
 
 	/* DMA Descriptor */
@@ -1118,7 +1118,7 @@ static void dwc2_set_parameters(struct dwc2_hsotg *hsotg,
 
 		dwc2_set_param_bool(hsotg, &p->host_dma,
 				    false, "host-dma",
-				    true, false,
+				    dma_capable, false,
 				    dma_capable);
 		dwc2_set_param_host_rx_fifo_size(hsotg,
 				params->host_rx_fifo_size);
-- 
1.7.9.5

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] usb: dwc2: fix parameter handling Stefan Wahren <stefan.wahren@i2se.com> - 2016-11-20 22:30 +0100
  [PATCH 4/5] usb: dwc2: gadget: fix default value for gadget-dma-desc Stefan Wahren <stefan.wahren@i2se.com> - 2016-11-20 22:30 +0100
  [PATCH 3/5] usb: dwc2: fix default value for DMA support Stefan Wahren <stefan.wahren@i2se.com> - 2016-11-20 22:30 +0100
  [PATCH 1/5] usb: dwc2: Do not set host parameter in peripheral mode Stefan Wahren <stefan.wahren@i2se.com> - 2016-11-20 22:30 +0100
  Re: [PATCH 0/5] usb: dwc2: fix parameter handling John Youn <John.Youn@synopsys.com> - 2016-11-22 01:00 +0100
    Re: [PATCH 0/5] usb: dwc2: fix parameter handling Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-11-22 13:10 +0100

csiph-web