Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1526301

[PATCH 4/5] usb: dwc2: gadget: fix default value for gadget-dma-desc

Show all headers | View raw

The current default for gadget DMA descriptor results on bcm2835 in a
unnecessary error message:

  Invalid value 1 for param gadget-dma-desc

So fix this by using hw->dma_desc_enable as default value.

Fixes: dec4b55677e ("usb: dwc2: gadget: Add descriptor DMA parameter")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 drivers/usb/dwc2/params.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 30b954e..11fe68a 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -1094,7 +1094,7 @@ static void dwc2_set_gadget_dma(struct dwc2_hsotg *hsotg)
 	/* DMA Descriptor */
 	dwc2_set_param_bool(hsotg, &p->g_dma_desc, false,
 			    "gadget-dma-desc",
-			    p->g_dma, false,
+			    !!hw->dma_desc_enable, false,
 			    !!hw->dma_desc_enable);
 }
 
-- 
1.7.9.5

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] usb: dwc2: fix parameter handling Stefan Wahren <stefan.wahren@i2se.com> - 2016-11-20 22:30 +0100
  [PATCH 4/5] usb: dwc2: gadget: fix default value for gadget-dma-desc Stefan Wahren <stefan.wahren@i2se.com> - 2016-11-20 22:30 +0100
  [PATCH 3/5] usb: dwc2: fix default value for DMA support Stefan Wahren <stefan.wahren@i2se.com> - 2016-11-20 22:30 +0100
  [PATCH 1/5] usb: dwc2: Do not set host parameter in peripheral mode Stefan Wahren <stefan.wahren@i2se.com> - 2016-11-20 22:30 +0100
  Re: [PATCH 0/5] usb: dwc2: fix parameter handling John Youn <John.Youn@synopsys.com> - 2016-11-22 01:00 +0100
    Re: [PATCH 0/5] usb: dwc2: fix parameter handling Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-11-22 13:10 +0100

csiph-web