Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1523566

Re: [PATCH] mvsas: fix command_active typo

Show all headers | View raw

On Wed, Nov 16, 2016 at 04:08:34PM +0100, Arnd Bergmann wrote:
> gcc-7 notices that the condition in mvs_94xx_command_active looks
> suspicious:
> 
> drivers/scsi/mvsas/mv_94xx.c: In function 'mvs_94xx_command_active':
> drivers/scsi/mvsas/mv_94xx.c:671:15: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]
> 
> This was introduced when the mv_printk() statement got added,
> and leads to the condition being ignored. This is probably harmless.
> 
> Changing '&&' to '&' makes the code look reasonable, as we check the
> command bit before setting and printing it.
> 
> Fixes: a4632aae8b66 ("[SCSI] mvsas: Add new macros and functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Looks reasonable,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mvsas: fix command_active typo Arnd Bergmann <arnd@arndb.de> - 2016-11-16 16:10 +0100
  Re: [PATCH] mvsas: fix command_active typo Johannes Thumshirn <jthumshirn@suse.de> - 2016-11-16 16:20 +0100
  Re: [PATCH] mvsas: fix command_active typo "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-11-17 03:00 +0100

csiph-web