Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1523565

Re: [PATCH 0/4] DW DMAC: update device tree

Show all headers | View raw

On Wed, 2016-11-16 at 16:56 +0300, Eugeniy Paltsev wrote:
> It wasn't possible to enable some features like
> memory-to-memory transfers or multi block transfers via DT.
> It is fixed by these patches.
> 
>  * Rename is_private to is-private as ordered by DT policy.
>  (just for cleanup) The change leaves the support for the 
>  old format.
> 
>  * Add is-memcpu property, so it is possible to
>  enable memory-to-memory transfers support via DT.
> 
>  * Add hw-llp property, so it is possible to enable
>  hardware multi block transfers support via DT.
> 
>  * Update DW DMAC device tree documentation.

I have few comments I posted. Besides that don't forget about current
users of the DT properties you standardized (by naming). Better you
convert them at the same time. Older DT (blobs) are being still
supported.

Otherwise looks okay after you address all my comments and maybe others
will do some. The DT people ACK is a must before this goes somewhere.

Also, please keep Cc list as small as possible. For example I'm not sure
Viresh has time to look at them, but he might keep an eye on the
dmaengine mailing list. Same about Dan.

> 
> Eugeniy Paltsev (4):
>   DW DMAC: rename is_private property as ordered by DT policy
>   DW DMAC: add is-memcpu property to device tree
>   DW DMAC: add hw-llp property to device tree
>   Update device tree Synopsys DW DMAC documentation
> 
>  Documentation/devicetree/bindings/dma/snps-dma.txt | 10 ++++++++--
>  drivers/dma/dw/core.c                              |  2 +-
>  drivers/dma/dw/platform.c                          | 10 ++++++++++
>  include/linux/platform_data/dma-dw.h               |  4 ++--
>  4 files changed, 21 insertions(+), 5 deletions(-)
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] DW DMAC: update device tree Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-11-16 15:00 +0100
  [PATCH 2/4] DW DMAC: add is-memcpu property to device tree Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-11-16 15:00 +0100
    Re: [PATCH 2/4] DW DMAC: add is-memcpu property to device tree Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-16 16:20 +0100
  [PATCH 1/4] DW DMAC: rename is_private property as ordered by DT policy Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-11-16 15:00 +0100
    Re: [PATCH 1/4] DW DMAC: rename is_private property as ordered by  DT policy Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-16 16:20 +0100
  [PATCH 3/4] DW DMAC: add hw-llp property to device tree Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2016-11-16 15:00 +0100
    Re: [PATCH 3/4] DW DMAC: add hw-llp property to device tree Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-16 16:20 +0100
  Re: [PATCH 0/4] DW DMAC: update device tree Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-11-16 16:20 +0100

csiph-web