Re: [RFC v3 2/6] Improve the tracking of active utilisation

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [RFC v3 2/6] Improve the tracking of active utilisation
Date	2016-11-18 20:00 +0100
Message-ID	<sEWyd-2tW-3@gated-at.bofh.it> (permalink)
References	<svO6S-ak-7@gated-at.bofh.it> <svO6S-ak-31@gated-at.bofh.it> <sETAm-xQ-13@gated-at.bofh.it> <sETTI-Xh-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Nov 18, 2016 at 05:06:50PM +0100, luca abeni wrote:
> 
> > Also, what happens when hrtimer_try_to_cancel() fails?
> 
> This is something I am working on... My original idea was that nothing
> bad happens, because the timer handler will see the task as RUNNING and
> will not decrease the running bw... But this is wrong.
> My new idea is to add a "dl_contending" flag in the scheduling entity,
> that indicates if the running bw has already been subtracted or not.
> With this, the issue should be solved (if anyone sees additional
> issues, or a better solution that does not require an additional flag,
> let me know).

Right. My suggestion would be to make it obvious, use that flag if
that's what it takes. We can always try and be clever later.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC v3 2/6] Improve the tracking of active utilisation Peter Zijlstra <peterz@infradead.org> - 2016-11-18 16:50 +0100
  Re: [RFC v3 2/6] Improve the tracking of active utilisation luca abeni <luca.abeni@unitn.it> - 2016-11-18 17:10 +0100
    Re: [RFC v3 2/6] Improve the tracking of active utilisation Peter Zijlstra <peterz@infradead.org> - 2016-11-18 20:00 +0100

csiph-web