Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1525470
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC v3 2/6] Improve the tracking of active utilisation |
| Date | 2016-11-18 16:50 +0100 |
| Message-ID | <sETAm-xQ-13@gated-at.bofh.it> (permalink) |
| References | <svO6S-ak-7@gated-at.bofh.it> <svO6S-ak-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Oct 24, 2016 at 04:06:34PM +0200, Luca Abeni wrote:
> @@ -1074,6 +1161,14 @@ select_task_rq_dl(struct task_struct *p, int cpu, int sd_flag, int flags)
> }
> rcu_read_unlock();
>
> + rq = task_rq(p);
> + raw_spin_lock(&rq->lock);
> + if (hrtimer_active(&p->dl.inactive_timer)) {
> + sub_running_bw(&p->dl, &rq->dl);
> + hrtimer_try_to_cancel(&p->dl.inactive_timer);
> + }
> + raw_spin_unlock(&rq->lock);
Its a bit sad having to take rq->lock here...
Also, what happens when hrtimer_try_to_cancel() fails?
> +
> out:
> return cpu;
> }
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [RFC v3 2/6] Improve the tracking of active utilisation Peter Zijlstra <peterz@infradead.org> - 2016-11-18 16:50 +0100
Re: [RFC v3 2/6] Improve the tracking of active utilisation luca abeni <luca.abeni@unitn.it> - 2016-11-18 17:10 +0100
Re: [RFC v3 2/6] Improve the tracking of active utilisation Peter Zijlstra <peterz@infradead.org> - 2016-11-18 20:00 +0100
csiph-web