Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1525547
| From | Andi Kleen <andi@firstfloor.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] x86/mce: Include the PPIN in machine check records when it is available |
| Date | 2016-11-18 18:10 +0100 |
| Message-ID | <sEUPL-1xM-11@gated-at.bofh.it> (permalink) |
| References | <sEFnH-84w-9@gated-at.bofh.it> <sEFnH-84w-7@gated-at.bofh.it> <sER5v-7vL-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Borislav Petkov <bp@suse.de> writes:
>
>> @@ -2134,8 +2140,37 @@ static int __init mcheck_enable(char *str)
>> }
>> __setup("mce", mcheck_enable);
>>
>> +static void mcheck_intel_ppin_init(void)
>
> So this functionality could all be moved to arch/x86/kernel/cpu/intel.c
> where you could set an artificial X86_FEATURE_PPIN and get rid of the
> have_ppin var.
That means that a tiny kernel that compiles out machine check
functionality has this unnecessary code.
In general it doesn't make any sense to define a FEATURE flag for
a single user. It's better to just check it where it is needed.
-Andi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2] mcelog: Print the PPIN in machine check records when it is available "Luck, Tony" <tony.luck@intel.com> - 2016-11-18 01:40 +0100
[PATCH 1/2] x86/mce: Include the PPIN in machine check records when it is available "Luck, Tony" <tony.luck@intel.com> - 2016-11-18 01:40 +0100
Re: [PATCH 1/2] x86/mce: Include the PPIN in machine check records when it is available Borislav Petkov <bp@suse.de> - 2016-11-18 14:10 +0100
Re: [PATCH 1/2] x86/mce: Include the PPIN in machine check records when it is available "Luck, Tony" <tony.luck@intel.com> - 2016-11-18 17:50 +0100
Re: [PATCH 1/2] x86/mce: Include the PPIN in machine check records when it is available Andi Kleen <andi@firstfloor.org> - 2016-11-18 18:10 +0100
Re: [PATCH 1/2] x86/mce: Include the PPIN in machine check records when it is available Borislav Petkov <bp@suse.de> - 2016-11-18 18:50 +0100
[PATCH v2] x86/mce: Include the PPIN in machine check records when it is available "Luck, Tony" <tony.luck@intel.com> - 2016-11-18 18:50 +0100
Re: [PATCH v2] x86/mce: Include the PPIN in machine check records when it is available Borislav Petkov <bp@suse.de> - 2016-11-23 12:50 +0100
Re: [PATCH v2] x86/mce: Include the PPIN in machine check records when it is available Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-11-23 14:40 +0100
Re: [PATCH v2] x86/mce: Include the PPIN in machine check records when it is available Borislav Petkov <bp@suse.de> - 2016-11-23 14:40 +0100
Re: [PATCH v2] x86/mce: Include the PPIN in machine check records when it is available Borislav Petkov <bp@suse.de> - 2016-11-23 16:00 +0100
Re: [PATCH v2] x86/mce: Include the PPIN in machine check records when it is available Tony Luck <tony.luck@gmail.com> - 2016-11-23 17:50 +0100
Re: [PATCH v2] x86/mce: Include the PPIN in machine check records when it is available Borislav Petkov <bp@suse.de> - 2016-11-23 18:00 +0100
Re: [PATCH v2] x86/mce: Include the PPIN in machine check records when it is available Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-11-23 18:30 +0100
Re: [PATCH v2] x86/mce: Include the PPIN in machine check records when it is available Tony Luck <tony.luck@gmail.com> - 2016-11-23 22:00 +0100
Re: [PATCH v2] x86/mce: Include the PPIN in machine check records when it is available Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-11-24 12:30 +0100
[tip:ras/core] x86/mce: Include the PPIN in MCE records when available tip-bot for Tony Luck <tipbot@zytor.com> - 2016-11-23 17:00 +0100
csiph-web