Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1525284
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/2] ACPI / processor: Make acpi_processor_ppc_has_changed() void |
| Date | 2016-11-18 14:00 +0100 |
| Message-ID | <sEQVQ-7dC-11@gated-at.bofh.it> (permalink) |
| References | <sEQVQ-7dC-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
The return value of acpi_processor_ppc_has_changed() is never used,
so make it void.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/processor_perflib.c | 10 ++++------
include/acpi/processor.h | 2 +-
2 files changed, 5 insertions(+), 7 deletions(-)
Index: linux-pm/drivers/acpi/processor_perflib.c
===================================================================
--- linux-pm.orig/drivers/acpi/processor_perflib.c
+++ linux-pm/drivers/acpi/processor_perflib.c
@@ -157,7 +157,7 @@ static void acpi_processor_ppc_ost(acpi_
status, NULL);
}
-int acpi_processor_ppc_has_changed(struct acpi_processor *pr, int event_flag)
+void acpi_processor_ppc_has_changed(struct acpi_processor *pr, int event_flag)
{
int ret;
@@ -168,7 +168,7 @@ int acpi_processor_ppc_has_changed(struc
*/
if (event_flag)
acpi_processor_ppc_ost(pr->handle, 1);
- return 0;
+ return;
}
ret = acpi_processor_get_platform_limit(pr);
@@ -182,10 +182,8 @@ int acpi_processor_ppc_has_changed(struc
else
acpi_processor_ppc_ost(pr->handle, 0);
}
- if (ret < 0)
- return (ret);
- else
- return cpufreq_update_policy(pr->id);
+ if (ret >= 0)
+ cpufreq_update_policy(pr->id);
}
int acpi_processor_get_bios_limit(int cpu, unsigned int *limit)
Index: linux-pm/include/acpi/processor.h
===================================================================
--- linux-pm.orig/include/acpi/processor.h
+++ linux-pm/include/acpi/processor.h
@@ -295,7 +295,7 @@ static inline void acpi_processor_ffh_cs
#ifdef CONFIG_CPU_FREQ
void acpi_processor_ppc_init(void);
void acpi_processor_ppc_exit(void);
-int acpi_processor_ppc_has_changed(struct acpi_processor *pr, int event_flag);
+void acpi_processor_ppc_has_changed(struct acpi_processor *pr, int event_flag);
extern int acpi_processor_get_bios_limit(int cpu, unsigned int *limit);
#else
static inline void acpi_processor_ppc_init(void)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] ACPI / processor / cpufreq: Function return value cleanups "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-18 14:00 +0100 [PATCH 2/2] cpufreq: Make cpufreq_update_policy() void "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-18 14:00 +0100 [PATCH 1/2] ACPI / processor: Make acpi_processor_ppc_has_changed() void "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-18 14:00 +0100 Re: [PATCH 0/2] ACPI / processor / cpufreq: Function return value cleanups Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-21 04:40 +0100
csiph-web