Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1524870

Re: [REVIEW][PATCH 2/3] ptrace: Don't allow accessing an undumpable mm

From Kees Cook <keescook@chromium.org>
Newsgroups linux.kernel
Subject Re: [REVIEW][PATCH 2/3] ptrace: Don't allow accessing an undumpable mm
Date 2016-11-18 00:20 +0100
Message-ID <sEE8i-7lb-7@gated-at.bofh.it> (permalink)
References (8 earlier) <sEBN8-5Dy-15@gated-at.bofh.it> <sEC6t-5ZL-1@gated-at.bofh.it> <sECzw-6bD-7@gated-at.bofh.it> <sECSS-6iy-5@gated-at.bofh.it> <sEDOW-6Zj-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 17, 2016 at 2:50 PM, Eric W. Biederman
<ebiederm@xmission.com> wrote:
>
> It is the reasonable expectation that if an executable file is not
> readable there will be no way for a user without special privileges to
> read the file.  This is enforced in ptrace_attach but if ptrace
> is already attached before exec there is no enforcement for read-only
> executables.

Given the corner cases being fixed here, it might make sense to add
some simple tests to tools/testing/sefltests/ptrace/ to validate these
changes and avoid future regressions.

Regardless, it'll be nice to have this fixed. :)

-Kees

-- 
Kees Cook
Nexus Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[REVIEW][PATCH 0/3] Fixing ptrace vs exec vs userns interactions ebiederm@xmission.com (Eric W. Biederman) - 2016-11-17 18:10 +0100
  [REVIEW][PATCH 1/3] ptrace: Capture the ptracer's creds not PT_PTRACE_CAP ebiederm@xmission.com (Eric W. Biederman) - 2016-11-17 18:20 +0100
    Re: [REVIEW][PATCH 1/3] ptrace: Capture the ptracer's creds not PT_PTRACE_CAP Kees Cook <keescook@chromium.org> - 2016-11-18 00:20 +0100
      Re: [REVIEW][PATCH 1/3] ptrace: Capture the ptracer's creds not PT_PTRACE_CAP ebiederm@xmission.com (Eric W. Biederman) - 2016-11-18 20:00 +0100
    Re: [REVIEW][PATCH 1/3] ptrace: Capture the ptracer's creds not PT_PTRACE_CAP Andy Lutomirski <luto@amacapital.net> - 2016-11-18 00:30 +0100
      Re: [REVIEW][PATCH 1/3] ptrace: Capture the ptracer's creds not PT_PTRACE_CAP ebiederm@xmission.com (Eric W. Biederman) - 2016-11-18 00:50 +0100
  [REVIEW][PATCH 3/3] exec: Ensure mm->user_ns contains the execed files ebiederm@xmission.com (Eric W. Biederman) - 2016-11-17 18:20 +0100
  [REVIEW][PATCH 2/3] exec: Don't allow ptracing an exec of an unreadable file ebiederm@xmission.com (Eric W. Biederman) - 2016-11-17 18:20 +0100
    Re: [REVIEW][PATCH 2/3] exec: Don't allow ptracing an exec of an  unreadable file Willy Tarreau <w@1wt.eu> - 2016-11-17 21:50 +0100
      Re: [REVIEW][PATCH 2/3] exec: Don't allow ptracing an exec of an  unreadable file Kees Cook <keescook@chromium.org> - 2016-11-17 22:10 +0100
        Re: [REVIEW][PATCH 2/3] exec: Don't allow ptracing an exec of an  unreadable file Willy Tarreau <w@1wt.eu> - 2016-11-17 22:40 +0100
          Re: [REVIEW][PATCH 2/3] exec: Don't allow ptracing an exec of an unreadable file ebiederm@xmission.com (Eric W. Biederman) - 2016-11-17 23:00 +0100
            [REVIEW][PATCH 2/3] ptrace: Don't allow accessing an undumpable mm ebiederm@xmission.com (Eric W. Biederman) - 2016-11-18 00:00 +0100
              Re: [REVIEW][PATCH 2/3] ptrace: Don't allow accessing an undumpable mm Kees Cook <keescook@chromium.org> - 2016-11-18 00:20 +0100
        Re: [REVIEW][PATCH 2/3] exec: Don't allow ptracing an exec of an  unreadable file Andy Lutomirski <luto@amacapital.net> - 2016-11-18 00:30 +0100
    Re: [REVIEW][PATCH 2/3] exec: Don't allow ptracing an exec of an  unreadable file Andy Lutomirski <luto@amacapital.net> - 2016-11-18 00:40 +0100
      Re: [REVIEW][PATCH 2/3] exec: Don't allow ptracing an exec of an unreadable file ebiederm@xmission.com (Eric W. Biederman) - 2016-11-18 01:00 +0100
        Re: [REVIEW][PATCH 2/3] exec: Don't allow ptracing an exec of an  unreadable file Andy Lutomirski <luto@amacapital.net> - 2016-11-18 01:20 +0100
          Re: [REVIEW][PATCH 2/3] exec: Don't allow ptracing an exec of an unreadable file ebiederm@xmission.com (Eric W. Biederman) - 2016-11-18 01:40 +0100
  Re: [REVIEW][PATCH 0/3] Fixing ptrace vs exec vs userns interactions Willy Tarreau <w@1wt.eu> - 2016-11-19 08:20 +0100
    Re: [REVIEW][PATCH 0/3] Fixing ptrace vs exec vs userns interactions Willy Tarreau <w@1wt.eu> - 2016-11-19 10:30 +0100
      Re: [REVIEW][PATCH 0/3] Fixing ptrace vs exec vs userns interactions Willy Tarreau <w@1wt.eu> - 2016-11-19 10:40 +0100
      Re: [REVIEW][PATCH 0/3] Fixing ptrace vs exec vs userns interactions ebiederm@xmission.com (Eric W. Biederman) - 2016-11-19 19:50 +0100
    Re: [REVIEW][PATCH 0/3] Fixing ptrace vs exec vs userns interactions ebiederm@xmission.com (Eric W. Biederman) - 2016-11-19 19:40 +0100
      Re: [REVIEW][PATCH 0/3] Fixing ptrace vs exec vs userns interactions ebiederm@xmission.com (Eric W. Biederman) - 2016-11-19 19:50 +0100

csiph-web