Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1521859

[PATCH tip/core/rcu 2/7] rcu: Remove obsolete rcu_check_callbacks() header comment

Show all headers | View raw

In the deep past, rcu_check_callbacks() was only invoked if rcu_pending()
returned true.  Which was fine, but these days rcu_check_callbacks()
is invoked unconditionally.  This commit therefore removes the obsolete
sentence from the header comment.

Reported-by: Michalis Kokologiannakis <mixaskok@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 kernel/rcu/tree.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 37e4f7d2be0c..d52780024f9f 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -2828,8 +2828,7 @@ static void rcu_do_batch(struct rcu_state *rsp, struct rcu_data *rdp)
  * Also schedule RCU core processing.
  *
  * This function must be called from hardirq context.  It is normally
- * invoked from the scheduling-clock interrupt.  If rcu_pending returns
- * false, there is no point in invoking rcu_check_callbacks().
+ * invoked from the scheduling-clock interrupt.
  */
 void rcu_check_callbacks(int user)
 {
-- 
2.5.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH tip/core/rcu 0/7] Miscellaneous fixes for 4.10 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 3/7] rcu: Remove obsolete comment from __call_rcu() "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 2/7] rcu: Remove obsolete rcu_check_callbacks() header comment "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 4/7] rcu: RCU_TRACE enables event tracing as well as debugfs "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 7/7] rcu: Don't kick unless grace period or request "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 1/7] rcu: Tighten up __call_rcu() rcu_head alignment check "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods recheck dyntick idle state "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
    Re: [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods  recheck dyntick idle state Josh Triplett <josh@joshtriplett.org> - 2016-11-14 18:30 +0100
      Re: [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods  recheck dyntick idle state Peter Zijlstra <peterz@infradead.org> - 2016-11-14 18:40 +0100
        Re: [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods  recheck dyntick idle state "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 19:20 +0100
          Re: [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods  recheck dyntick idle state Peter Zijlstra <peterz@infradead.org> - 2016-11-15 09:20 +0100
            Re: [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods  recheck dyntick idle state "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-15 15:40 +0100
  [PATCH tip/core/rcu 5/7] torture: Trace long read-side delays "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
    Re: [PATCH tip/core/rcu 5/7] torture: Trace long read-side delays Josh Triplett <josh@joshtriplett.org> - 2016-11-14 18:30 +0100
      Re: [PATCH tip/core/rcu 5/7] torture: Trace long read-side delays "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 19:50 +0100
        Re: [PATCH tip/core/rcu 5/7] torture: Trace long read-side delays Josh Triplett <josh@joshtriplett.org> - 2016-11-14 20:00 +0100
  Re: [PATCH tip/core/rcu 0/7] Miscellaneous fixes for 4.10 Josh Triplett <josh@joshtriplett.org> - 2016-11-14 18:30 +0100

csiph-web