Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1521857

[PATCH tip/core/rcu 3/7] rcu: Remove obsolete comment from __call_rcu()

Show all headers | View raw

The __call_rcu() comment about opportunistically noting grace period
beginnings and endings is obsolete.  RCU still does such opportunistic
noting, but in __call_rcu_core() rather than __call_rcu(), and there
already is an appropriate comment in __call_rcu_core().  This commit
therefore removes the obsolete comment.

Reported-by: Michalis Kokologiannakis <mixaskok@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 kernel/rcu/tree.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index d52780024f9f..865af187498e 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3131,13 +3131,6 @@ __call_rcu(struct rcu_head *head, rcu_callback_t func,
 	}
 	head->func = func;
 	head->next = NULL;
-
-	/*
-	 * Opportunistically note grace-period endings and beginnings.
-	 * Note that we might see a beginning right after we see an
-	 * end, but never vice versa, since this CPU has to pass through
-	 * a quiescent state betweentimes.
-	 */
 	local_irq_save(flags);
 	rdp = this_cpu_ptr(rsp->rda);
 
-- 
2.5.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH tip/core/rcu 0/7] Miscellaneous fixes for 4.10 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 3/7] rcu: Remove obsolete comment from __call_rcu() "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 2/7] rcu: Remove obsolete rcu_check_callbacks() header comment "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 4/7] rcu: RCU_TRACE enables event tracing as well as debugfs "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 7/7] rcu: Don't kick unless grace period or request "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 1/7] rcu: Tighten up __call_rcu() rcu_head alignment check "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
  [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods recheck dyntick idle state "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
    Re: [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods  recheck dyntick idle state Josh Triplett <josh@joshtriplett.org> - 2016-11-14 18:30 +0100
      Re: [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods  recheck dyntick idle state Peter Zijlstra <peterz@infradead.org> - 2016-11-14 18:40 +0100
        Re: [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods  recheck dyntick idle state "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 19:20 +0100
          Re: [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods  recheck dyntick idle state Peter Zijlstra <peterz@infradead.org> - 2016-11-15 09:20 +0100
            Re: [PATCH tip/core/rcu 6/7] rcu: Make expedited grace periods  recheck dyntick idle state "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-15 15:40 +0100
  [PATCH tip/core/rcu 5/7] torture: Trace long read-side delays "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 18:00 +0100
    Re: [PATCH tip/core/rcu 5/7] torture: Trace long read-side delays Josh Triplett <josh@joshtriplett.org> - 2016-11-14 18:30 +0100
      Re: [PATCH tip/core/rcu 5/7] torture: Trace long read-side delays "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-11-14 19:50 +0100
        Re: [PATCH tip/core/rcu 5/7] torture: Trace long read-side delays Josh Triplett <josh@joshtriplett.org> - 2016-11-14 20:00 +0100
  Re: [PATCH tip/core/rcu 0/7] Miscellaneous fixes for 4.10 Josh Triplett <josh@joshtriplett.org> - 2016-11-14 18:30 +0100

csiph-web